Forbedre ytelse på identpool #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced new methods in `IdentRepository` to count and find `Ident` entities based on various parameters including `Rekvireringsstatus`, `Identtype`, `Syntetisk`, `Kjoenn`, and date range. Updated `DatabaseService` to utilize these new repository methods, enhancing the service's querying capabilities.
#deploy-testnav-ident-pool Revised methods for fetching and counting Idents in `DatabaseService` to improve query efficiency. Enabled H2 database console for local development and included sample data for testing. Adjusted security configurations to accommodate new endpoints and data sources.
#deploy-testnav-ident-pool Modified the tests to ensure that identifier generation does not throw an exception when the desired amount of identifiers cannot be generated. Instead, the tests now assert that the resulting set size is less than the requested amount.
#deploy-testnav-ident-pool Added HikariCP datasource configuration with minimum idle connections set to 10 and maximum pool size set to 100 to improve database connection management. This change is intended to optimize performance and resource utilization.
#deploy-testnav-ident-pool This commit adds a new SQL migration script (V1.3.1__IndeksSyntetisk.sql) that creates an index for the 'syntetisk' column in the 'personidentifikator' table. This change is aimed at improving query performance involving the 'syntetisk' column.
#deploy-testnav-ident-pool Changed the PostgreSQL version from 15 to 16 in the configuration file. This update ensures compatibility with the latest features and improvements provided by PostgreSQL 16.
#deploy-testnav-ident-pool Adjusting the CPU request limit ensures that the application has sufficient resources to handle increased load. This change aims to prevent potential performance issues under higher demand.
stigus
approved these changes
Oct 11, 2024
…t-pool Inserted additional `personidentifikator` entries to the H2 database initialization script and adjusted the sequence restart point. Enhanced logging in `PoolService` to include the count of generated identifiers and increased the number of attempts for synthetic identifier generation.
Changed variable names to improve code readability and consistency in the `allocateIdenter` method. Replaced `List<Ident>` with `var` keyword for type inference. These changes should help streamline future modifications and maintenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new methods in
IdentRepositoryto count and findIdententities based on various parameters includingRekvireringsstatus,Identtype,Syntetisk,Kjoenn, and date range. UpdatedDatabaseServiceto utilize these new repository methods, enhancing the service's querying capabilities.