feat: workaround missing string sanitization in .NET Core

this version is finally working fixes issues with lack of HTTP header sanitization in .NET Core, see: - NixOS/nixpkgs#315574 - microsoftgraph/msgraph-cli#477 Signed-off-by: Krzysztof Nazarewski <[email protected]>
nazarewk-iac · May 29, 2024 · 5a76297 · Lillecarl · May 30, 2024 · nazarewk
1 parent bec9cdc
commit 5a76297
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/modules/ascii-workaround.nix b/modules/ascii-workaround.nix
@@ -0,0 +1,19 @@
+/* Last reviewied: 2024-05-29
+
+  fixes issues with lack of HTTP header sanitization in .NET Core, see:
+  - https://github.com/NixOS/nixpkgs/issues/315574
+  - https://github.com/microsoftgraph/msgraph-cli/issues/477
+*/
+{ lib, options, ... }: {
+  /*
+    using just `readOnly` because it can contain neither of: default, example, description, apply, type
+    see https://github.com/NixOS/nixpkgs/blob/aae38d0d557d2f0e65b2ea8e1b92219f2c0ea8f9/lib/modules.nix#L752-L756
+   */
+  options.system.nixos.codeName = lib.mkOption { readOnly = false; };
+  config.system.nixos.codeName =
+    let
+      codeName = options.system.nixos.codeName.default;
+      renames."Vicuña" = "Vicuna";
+    in
+      renames."${codeName}" or (throw "Unknown `codeName`: ${codeName}, please add it to `renames` in `ascii-workaround.nix`");
+}
diff --git a/modules/default.nix b/modules/default.nix
@@ -1,5 +1,6 @@
 { config, lib, pkgs, inputs, self, ... }: {
   imports = [
+    ./ascii-workaround.nix
     inputs.home-manager.nixosModules.home-manager
     inputs.disko.nixosModules.disko
     ./nix.nix

diff --git a/modules/profile/machine/baseline/default.nix b/modules/profile/machine/baseline/default.nix
@@ -156,6 +156,5 @@ in
           (builtins.concatStringsSep "\n")
         ];
     }
-    (lib.mkIf (lib.trivial.codeName == "Vicuña") { system.nixos.codeName = lib.mkForce "Vicuna"; })
   ]);
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -156,6 +156,5 @@ in @@
               (builtins.concatStringsSep "\n")
             ];
         }
-        (lib.mkIf (lib.trivial.codeName == "Vicuña") { system.nixos.codeName = lib.mkForce "Vicuna"; })
       ]);
     }