bugfix: handle new rate-limits for querying pools #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akorchyn
requested review from
FroVolod,
dj8yfo and
PolyProgrammist
as code owners
|
@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 8! @frolvanya received 25 Sloth Points for reviewing and scoring this pull request. Another weekly streak completed, well done @akorchyn! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
akorchyn
changed the title
frolvanya
requested changes
Dec 23, 2024
|
@race-of-sloths score 3 |
dj8yfo
reviewed
Dec 23, 2024
|
@race-of-sloths score 13 |
akorchyn
deleted the
431-view-account-summary-method-doesnt-work-on-testnet-network
branch
Merged
|
LGTM. I don't think there should be a separate ConfigV3 struct as it is the same as V2. Though it's ok |
akorchyn
pushed a commit
that referenced
this pull request
Jan 20, 2025
## 🤖 New release * `near-cli-rs`: 0.17.0 -> 0.18.0 (⚠️ API breaking changes) ###⚠️ `near-cli-rs` breaking changes ``` --- failure enum_no_repr_variant_discriminant_changed: enum variant had its discriminant change value --- Description: The enum's variant had its discriminant value change. This breaks downstream code that used its value via a numeric cast like `as isize`. ref: https://doc.rust-lang.org/reference/items/enumerations.html#assigning-discriminant-values impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_no_repr_variant_discriminant_changed.ron Failed in: variant AccountActionsDiscriminants::AddKey 7 -> 8 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:68 variant AccountActionsDiscriminants::DeleteKeys 8 -> 9 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:73 variant AccountActionsDiscriminants::ManageStorageDeposit 9 -> 10 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:78 variant AccountActionsDiscriminants::AddKey 7 -> 8 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:68 variant AccountActionsDiscriminants::DeleteKeys 8 -> 9 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:73 variant AccountActionsDiscriminants::ManageStorageDeposit 9 -> 10 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:78 --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_variant_added.ron Failed in: variant AccountActionsDiscriminants:GetPublicKey in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:63 variant AccountActionsDiscriminants:GetPublicKey in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:63 variant CliAccountActions:GetPublicKey in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:24 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.18.0](v0.17.0...v0.18.0) - 2025-01-20 ### Added - Added the ability to get a public key for an account (#436) ### Other - fixed migration. Added migration saving to be more clear (#434) - handle new rate-limits for querying pools (#433) - Extended the documentation for building NEAR CLI from the source code (#430) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #431
Ideally, if Fastnear is stable enough, the user shouldn't be able to hit this limit as we will query information within the pools the user has staked before.
But in case the fastener fails, we would need to query all active pools, which number more than 150.
@race-of-sloths