Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements about subqueries. #845

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

tonioo
Copy link
Collaborator

@tonioo tonioo commented Dec 10, 2024

This PR brings the following changes:

  • Fix an issue where subquery params were not injected into the final cypher query
  • Better way to specify subquery initial context (variables)
  • Use of "self" keyword within a NodeNameResolver call to reference top-level node

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (4941d1d) to head (6c8a1f1).
Report is 6 commits behind head on rc/5.4.2.

Additional details and impacted files
@@             Coverage Diff              @@
##           rc/5.4.2     #845      +/-   ##
============================================
+ Coverage     92.66%   92.75%   +0.08%     
============================================
  Files            35       35              
  Lines          5401     5438      +37     
============================================
+ Hits           5005     5044      +39     
+ Misses          396      394       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariusconjeaud mariusconjeaud merged commit a0c0c00 into rc/5.4.2 Dec 10, 2024
4 checks passed
@mariusconjeaud mariusconjeaud deleted the fix/subquery_filter_values branch December 10, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants