Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on NaN #349

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix crash on NaN #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b175cb
Fix crash on NaN
thebestnom May 23, 2023
90ebf3d
2.1.1-alpha1
thebestnom May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion __tests__/neovis.tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,8 @@ describe('Neovis', () => {
test6: new Neo4j.types.LocalTime(1, 2, 3, 4),
test7: new Neo4j.types.Point(1, 2, 3, 4),
test8: new Neo4j.types.Point(1, 2, 3),
test9: new Neo4j.types.Time(1, 2, 3, 4, 5)
test9: new Neo4j.types.Time(1, 2, 3, 4, 5),
test10: NaN
}),
new Neo4j.types.Relationship(new Neo4j.types.Integer(0, 0), new Neo4j.types.Integer(0, 0), new Neo4j.types.Integer(1, 0), 'TEST', {}),
new Neo4j.types.Path(
Expand Down Expand Up @@ -647,6 +648,7 @@ describe('Neovis', () => {
expect(neovis.nodes.get(1)?.raw.properties.test7).toBeInstanceOf(Neo4j.types.Point);
expect(neovis.nodes.get(1)?.raw.properties.test8).toBeInstanceOf(Neo4j.types.Point);
expect(neovis.nodes.get(1)?.raw.properties.test9).toBeInstanceOf(Neo4j.types.Time);
expect(neovis.nodes.get(1)?.raw.properties.test10).toBeNaN();
});
});
});
1 change: 0 additions & 1 deletion dist/main.map60ef0e3e7494c6dd3a6d
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions dist/main.map877f9266ed26e5e4321b
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/main.map591dd2c8384464a705c7 → dist/main.map9e0555983e992e5d5f0d
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/neovis-without-dependencies.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/neovis.js
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions docs/classes/EventController.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h4>Hierarchy</h4>
<ul class="tsd-hierarchy">
<li><span class="target">EventController</span></li></ul></section><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/events.ts#L17">src/events.ts:17</a></li></ul></aside>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/events.ts#L17">src/events.ts:17</a></li></ul></aside>
<section class="tsd-panel-group tsd-index-group">
<section class="tsd-panel tsd-index-panel">
<details class="tsd-index-content tsd-index-accordion" open><summary class="tsd-accordion-summary tsd-index-summary">
Expand All @@ -44,7 +44,7 @@ <h3 class="tsd-anchor-link"><span>constructor</span><a href="#constructor" aria-
<li class="tsd-description">
<h4 class="tsd-returns-title">Returns <a href="EventController.html" class="tsd-signature-type tsd-kind-class">EventController</a></h4><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/events.ts#L20">src/events.ts:20</a></li></ul></aside></li></ul></section></section>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/events.ts#L20">src/events.ts:20</a></li></ul></aside></li></ul></section></section>
<section class="tsd-panel-group tsd-member-group">
<h2>Methods</h2>
<section class="tsd-panel tsd-member"><a id="generateEvent" class="tsd-anchor"></a>
Expand All @@ -70,7 +70,7 @@ <h5><span class="tsd-kind-parameter">values</span>: <span class="tsd-signature-t
</div></li></ul></div>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">void</span></h4><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/events.ts#L47">src/events.ts:47</a></li></ul></aside></li></ul></section>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/events.ts#L47">src/events.ts:47</a></li></ul></aside></li></ul></section>
<section class="tsd-panel tsd-member"><a id="register" class="tsd-anchor"></a>
<h3 class="tsd-anchor-link"><span>register</span><a href="#register" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></h3>
<ul class="tsd-signatures">
Expand All @@ -94,7 +94,7 @@ <h5><span class="tsd-kind-parameter">handler</span>: <a href="../interfaces/Even
</div></li></ul></div>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">void</span></h4><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/events.ts#L34">src/events.ts:34</a></li></ul></aside></li></ul></section></section></div>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/events.ts#L34">src/events.ts:34</a></li></ul></aside></li></ul></section></section></div>
<div class="col-sidebar">
<div class="page-menu">
<div class="tsd-navigation settings">
Expand Down
38 changes: 19 additions & 19 deletions docs/classes/NeoVis.html
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions docs/enums/NeoVisEvents.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<li><a href="NeoVisEvents.html">NeoVisEvents</a></li></ul>
<h1>Enumeration NeoVisEvents</h1></div><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/events.ts#L3">src/events.ts:3</a></li></ul></aside>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/events.ts#L3">src/events.ts:3</a></li></ul></aside>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we define this blob id in constants why if it predefined and use that constant here in url

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for testing specific commits

<section class="tsd-panel-group tsd-index-group">
<section class="tsd-panel tsd-index-panel">
<details class="tsd-index-content tsd-index-accordion" open><summary class="tsd-accordion-summary tsd-index-summary">
Expand All @@ -35,22 +35,22 @@ <h2>Enumeration Members</h2>
<h3 class="tsd-anchor-link"><span>Click<wbr/>Edge<wbr/>Event</span><a href="#ClickEdgeEvent" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><path stroke="none" d="M0 0h24v24H0z" fill="none" id="icon-anchor-a"></path><path d="M10 14a3.5 3.5 0 0 0 5 0l4 -4a3.5 3.5 0 0 0 -5 -5l-.5 .5" id="icon-anchor-b"></path><path d="M14 10a3.5 3.5 0 0 0 -5 0l-4 4a3.5 3.5 0 0 0 5 5l.5 -.5" id="icon-anchor-c"></path></svg></a></h3>
<div class="tsd-signature"><span class="tsd-kind-enum-member">Click<wbr/>Edge<wbr/>Event</span><span class="tsd-signature-symbol">:</span> <span class="tsd-signature-type">&quot;clickEdge&quot;</span></div><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/events.ts#L6">src/events.ts:6</a></li></ul></aside></section>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/events.ts#L6">src/events.ts:6</a></li></ul></aside></section>
<section class="tsd-panel tsd-member"><a id="ClickNodeEvent" class="tsd-anchor"></a>
<h3 class="tsd-anchor-link"><span>Click<wbr/>Node<wbr/>Event</span><a href="#ClickNodeEvent" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></h3>
<div class="tsd-signature"><span class="tsd-kind-enum-member">Click<wbr/>Node<wbr/>Event</span><span class="tsd-signature-symbol">:</span> <span class="tsd-signature-type">&quot;clickNode&quot;</span></div><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/events.ts#L5">src/events.ts:5</a></li></ul></aside></section>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/events.ts#L5">src/events.ts:5</a></li></ul></aside></section>
<section class="tsd-panel tsd-member"><a id="CompletionEvent" class="tsd-anchor"></a>
<h3 class="tsd-anchor-link"><span>Completion<wbr/>Event</span><a href="#CompletionEvent" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></h3>
<div class="tsd-signature"><span class="tsd-kind-enum-member">Completion<wbr/>Event</span><span class="tsd-signature-symbol">:</span> <span class="tsd-signature-type">&quot;completed&quot;</span></div><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/events.ts#L4">src/events.ts:4</a></li></ul></aside></section>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/events.ts#L4">src/events.ts:4</a></li></ul></aside></section>
<section class="tsd-panel tsd-member"><a id="ErrorEvent" class="tsd-anchor"></a>
<h3 class="tsd-anchor-link"><span>Error<wbr/>Event</span><a href="#ErrorEvent" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></h3>
<div class="tsd-signature"><span class="tsd-kind-enum-member">Error<wbr/>Event</span><span class="tsd-signature-symbol">:</span> <span class="tsd-signature-type">&quot;error&quot;</span></div><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/events.ts#L7">src/events.ts:7</a></li></ul></aside></section></section></div>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/events.ts#L7">src/events.ts:7</a></li></ul></aside></section></section></div>
<div class="col-sidebar">
<div class="page-menu">
<div class="tsd-navigation settings">
Expand Down
2 changes: 1 addition & 1 deletion docs/functions/migrateFromOldConfig.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ <h5><span class="tsd-kind-parameter">oldNeoVisConfig</span>: <a href="../interfa
</div></li></ul></div>
<h4 class="tsd-returns-title">Returns <a href="../interfaces/NeovisConfig.html" class="tsd-signature-type tsd-kind-interface">NeovisConfig</a></h4><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/neovis.ts#L852">src/neovis.ts:852</a></li></ul></aside></li></ul></section></div>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/neovis.ts#L854">src/neovis.ts:854</a></li></ul></aside></li></ul></section></div>
<div class="col-sidebar">
<div class="page-menu">
<div class="tsd-navigation settings">
Expand Down
2 changes: 1 addition & 1 deletion docs/functions/objectToTitleHtml.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ <h5><span class="tsd-kind-parameter">titleProperties</span>: <span class="tsd-si
</div></li></ul></div>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type ">HTMLDivElement</span></h4><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/neovis.ts#L196">src/neovis.ts:196</a></li></ul></aside></li></ul></section></div>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/neovis.ts#L198">src/neovis.ts:198</a></li></ul></aside></li></ul></section></div>
<div class="col-sidebar">
<div class="page-menu">
<div class="tsd-navigation settings">
Expand Down
2 changes: 1 addition & 1 deletion docs/functions/objectToTitleString.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ <h5><span class="tsd-kind-parameter">titleProperties</span>: <span class="tsd-si
</div></li></ul></div>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">string</span></h4><aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/cef0aa1/src/neovis.ts#L217">src/neovis.ts:217</a></li></ul></aside></li></ul></section></div>
<li>Defined in <a href="https://github.com/neo4j-contrib/neovis.js/blob/5b175cb/src/neovis.ts#L219">src/neovis.ts:219</a></li></ul></aside></li></ul></section></div>
<div class="col-sidebar">
<div class="page-menu">
<div class="tsd-navigation settings">
Expand Down
Loading