feat: add GitHub Actions for Cypress tests and code quality checks #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Updated actions scripts so they would run on more recent node versions.
szymonkadas
force-pushed
the
feat/github-actions
branch
from
00676fb to
120dd92
Compare
this is stupid.
added term to fight back error occuring in cypress run
szymonkadas
force-pushed
the
feat/github-actions
branch
from
bd86277 to
606de87
Compare
implemeting this: cypress-io/cypress#28061 (comment)
Sumick
requested changes
Dec 20, 2023
| const TextInputWithDropdown = () => { | ||
| interface TextInputWithDropdownProps { | ||
| dataTestId?: string | ||
| dataTestId2?: string |
There was a problem hiding this comment.
nitpick: we should not have to pass such props. Only id would be enough
yarn.lock
Outdated
There was a problem hiding this comment.
nitpick: yarn.lock to remove
| @@ -52,12 +60,14 @@ const TextInputWithDropdown = () => { | |||
| excludeDigits | |||
| onClick={handleCountryInputClick} | |||
| inputRef={inputRef} | |||
| dataTestId={dataTestId} | |||
There was a problem hiding this comment.
nitpick: No need to pass dataTest this deep, we can do it directly in component
| }: { | ||
| value: string | ||
| setIsDropdownActive: React.Dispatch<React.SetStateAction<boolean>> | ||
| dataTestId?: string | undefined |
There was a problem hiding this comment.
nitpick: We should not need such prop drilling here
| const user = await prisma.user.findUnique({ | ||
| where: { email }, | ||
| include: { profile: true }, | ||
| }) |
There was a problem hiding this comment.
nitpick: We should check it earlier:
const user = await prisma.user.findUnique({
where: { email },
include: { profile: true },
})
if (!user) {
throw Error("User not found")
}
await prisma.profile.delete({
where: { id: user.profile.id },
})
app/api/test/profile/route.ts
Outdated
There was a problem hiding this comment.
nitpick: Why /test path - we should add it normally in /api/profile/route.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.