Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-exist error field from IntegrationTestImpl rpc doc #4194

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Remove non-exist error field from IntegrationTestImpl rpc doc #4194

merged 4 commits into from
Oct 16, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Oct 16, 2023 •
edited
Loading

What problem does this PR solve?

The example response in IntegrationTestImpl are successful, then the "error": null won't appear in the response, remove them.

Related changes

  • Remove non-exist error field from IntegrationTestImpl rpc doc

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner October 16, 2023 05:31
@eval-exec eval-exec requested review from doitian and removed request for a team October 16, 2023 05:31
@eval-exec eval-exec changed the title Remove non-exist error field from IntegratinoTestImpl rpc doc Remove non-exist error field from IntegrationTestImpl rpc doc Oct 16, 2023
@eval-exec eval-exec requested a review from EthanYuan October 16, 2023 05:32
@eval-exec eval-exec added the t:doc Type: Documentation label Oct 16, 2023
@eval-exec eval-exec marked this pull request as draft October 16, 2023 05:34
@eval-exec eval-exec marked this pull request as ready for review October 16, 2023 05:40
@quake quake added this pull request to the merge queue Oct 16, 2023
Merged via the queue into nervosnetwork:develop with commit 58419a7 Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

@EthanYuan EthanYuan Awaiting requested review from EthanYuan

Assignees
No one assigned
Labels
t:doc Type: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @quake