Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init a temp DATA_DIR for bench-test #4280

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Init a temp DATA_DIR for bench-test #4280

merged 1 commit into from
Jan 3, 2024

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #4274

Problem Summary:

What is changed and how it works?

This PR want to set DATA_DIR as a temporary dir for make bench-test.
What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner December 26, 2023 07:36
@zhangsoledad zhangsoledad added this pull request to the merge queue Jan 3, 2024
Merged via the queue into nervosnetwork:develop with commit 0c33675 Jan 3, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected Dirty Files Generated After Running make bench-test in CKB Project
2 participants
@eval-exec @zhangsoledad