backport: Fix the websockets terminate issue #4332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
There is a trivial issue introduced in #4314, the
shutdown
layer didn't applied to websocket after the PR, which makes it will hung up when server terminate websocket.What is changed and how it works?
Fix the shutdown handler, make it's default for HTTP and Websocket, since we will always send exit signal in these two scenario, so we can make the code simpler.
What's Changed:
Related changes
owner/repo
:Check List
Tests
Side effects
Release note