Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alias ScriptVerifier for TransactionScriptsVerifier #4344

Merged
merged 1 commit into from
Feb 9, 2024
Merged

alias ScriptVerifier for TransactionScriptsVerifier #4344

merged 1 commit into from
Feb 9, 2024

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

The inner in ScriptVerifier is useless.

What is changed and how it works?

Clean up the inner, add alias ScriptVerifier for TransactionScriptsVerifier to keep compatible.

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner February 8, 2024 09:53
@chenyukang chenyukang requested review from doitian and removed request for a team February 8, 2024 09:53
@chenyukang chenyukang marked this pull request as draft February 8, 2024 09:54
@chenyukang chenyukang force-pushed the yukang-clean-ScriptVerifier branch from f6ccd9a to 18d21d0 Compare February 8, 2024 09:56
@chenyukang chenyukang force-pushed the yukang-clean-ScriptVerifier branch from 18d21d0 to 53ab472 Compare February 8, 2024 10:01
@chenyukang chenyukang marked this pull request as ready for review February 8, 2024 10:02
@quake quake added this pull request to the merge queue Feb 9, 2024
Merged via the queue into nervosnetwork:develop with commit cddcf9e Feb 9, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenyukang @quake