Federated fabric initial overlay management #205
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires update to the DCNM module for vrf as instance values required ipv4 and ipv6, but only one or both are the options
Merge branch 'Pete&Matt' of https://github.com/netascode/ansible-dc-vxlan into Pete&Matt
mikewiebe
reviewed
Oct 18, 2024
| vag = vrf_attach_group.get("name") | ||
| hn = switch.get("hostname") | ||
| results.append("VRF attach group {0} hostname {1} does not match any switch in the topology".format(vag, hn)) | ||
| if len(switches) > 0: |
There was a problem hiding this comment.
In a federated fabric we don't have swtiches
* Created action plugin for existing fabric links checking * Freeform int pre prov (#217) * Added support for interface freeform as well as allowing framework to proceed when no overlay services are supplied * Added support for external fabric onboarding. Does not include creation of the fabric as this is TODO. So fabric needs to exist in NDFC first * remove fix for tags issue * Re-inserting space at the top of the file
mikewiebe
reviewed
Dec 4, 2024
| if 'freeforms' in dm_check['keys_not_found'] or \ | ||
| 'freeforms' in dm_check['keys_no_data']: | ||
| self.model_data['vxlan']['topology']['switches'][list_index]['freeforms'] = [] | ||
| if self.model_data['vxlan'].get('topology', None) is not None: |
There was a problem hiding this comment.
I had planned to address the fact that there might not be topology data in a slightly different way. The changes are not in the develop branch yet but they are in our msd branch. Instead of the if check here, earlier I add the following check and set the topology data to an empty dict. That way we still build out the entire structure even if it's empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Related Collection Role
Related Data Model Element
Proposed Changes
Test Notes
Cisco NDFC Version
Checklist