Implement calc() #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlsa
force-pushed
the
tlsa/calc
branch
2 times, most recently
from
67364ac to
05a9ed4
Compare
Co-authored-by: Michael Drake <[email protected]>
Co-authored-by: Daniel Silverstone <[email protected]>
Co-authored-by: Michael Drake <[email protected]>
In order to permit us to share calc expressions between styles and computed styles, without copying, we embed the calc expression bytecode into an lwc string. This is effectively using lwc_string as an interned byte buffer, there may be a nicer way to do this in the future. Signed-off-by: Daniel Silverstone <[email protected]>
Without this we would fail to consume the bytecode belonging to calc value storage, and treat the data instead as the next op code, and jump beyond the end of the property dispatch table.
The computed style handling doesn't know how to deal with them yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.