-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link checker job #4116
Add link checker job #4116
Conversation
7035d0c
to
8dcb0a8
Compare
Signed-off-by: Mikhail Avramenko <[email protected]>
9b6661f
to
747fb91
Compare
.github/workflows/ci.yaml
Outdated
linkChecker: | ||
runs-on: ubuntu-latest | ||
container: | ||
image: lycheeverse/lychee:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the fixed version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fixed
.github/workflows/ci.yaml
Outdated
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
- name: Check external links using lychee | ||
run: | | ||
REF=$(grep --include=\*.md -r . -e '?ref=' | head -1 | cut -d '=' -f2) | ||
grep --include=\*.md -r . -e '?ref=' | while IFS= read -r line ; do | ||
NEW_FILENAME=$(echo "$line" | cut -d ':' -f1) | ||
if [ "$FILENAME" = "$NEW_FILENAME" ]; then | ||
continue | ||
fi | ||
FILENAME="$NEW_FILENAME" | ||
sed -i -e "s/github.com\/networkservicemesh\/deployments-k8s/github.com\/networkservicemesh\/deployments-k8s\/tree\/$REF/g" "$FILENAME" | ||
sed -i -e "s/?ref=$REF//g" "$FILENAME" | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
steps: | |
- name: Checkout | |
uses: actions/checkout@v2 | |
- name: Check external links using lychee | |
run: | | |
REF=$(grep --include=\*.md -r . -e '?ref=' | head -1 | cut -d '=' -f2) | |
grep --include=\*.md -r . -e '?ref=' | while IFS= read -r line ; do | |
NEW_FILENAME=$(echo "$line" | cut -d ':' -f1) | |
if [ "$FILENAME" = "$NEW_FILENAME" ]; then | |
continue | |
fi | |
FILENAME="$NEW_FILENAME" | |
sed -i -e "s/github.com\/networkservicemesh\/deployments-k8s/github.com\/networkservicemesh\/deployments-k8s\/tree\/$REF/g" "$FILENAME" | |
sed -i -e "s/?ref=$REF//g" "$FILENAME" | |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fixed
.github/workflows/ci.yaml
Outdated
sed -i -e "s/github.com\/networkservicemesh\/deployments-k8s/github.com\/networkservicemesh\/deployments-k8s\/tree\/$REF/g" "$FILENAME" | ||
sed -i -e "s/?ref=$REF//g" "$FILENAME" | ||
done | ||
lychee -v '**/*.md' --exclude-mail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lychee -v '**/*.md' --exclude-mail | |
lychee -v '**/*.md' --exclude-mail --exclude '.*?ref\=?.*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overcomplicated.
8e85491
to
cb594bd
Compare
Signed-off-by: Mikhail Avramenko <[email protected]>
cb594bd
to
7b5cd9e
Compare
…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#4116 Commit: eb73616 Author: Denis Tingaikin Date: 2021-12-23 11:57:16 +0300 Message: - Merge pull request #1241 from glazychev-art/describe_prefetch Signed-off-by: NSMBot <[email protected]>
Signed-off-by: Mikhail Avramenko [email protected]
Issue
closes #4053