add possibility to have no jitter with RandomFixedWindowSampler #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective is to have an in-between of
SequentialFixedWindowSampler
andRandomFixedWindowSampler
. We want to have samples drawn randomly but without any jitter.The functionality can be implemented in one of the two samplers.
After discussion with Vinam, the design choice was more oriented to
RandomFixedWindowSampler
.If there are better design choices do not hesitate!
With this implementation, Jitter can be disabled by setting
enable_jitter
toFalse
atRandomFixedWindowSampler
initialization