Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to have no jitter with RandomFixedWindowSampler #17

Closed
wants to merge 1 commit into from

Conversation

AlexandreAndr
Copy link
Contributor

The objective is to have an in-between of SequentialFixedWindowSampler and RandomFixedWindowSampler . We want to have samples drawn randomly but without any jitter.
The functionality can be implemented in one of the two samplers.
After discussion with Vinam, the design choice was more oriented to RandomFixedWindowSampler .
If there are better design choices do not hesitate!
With this implementation, Jitter can be disabled by setting enable_jitter to False at RandomFixedWindowSampler initialization

@AlexandreAndr AlexandreAndr requested a review from mazabou November 1, 2024 22:21
@AlexandreAndr AlexandreAndr self-assigned this Nov 1, 2024
@mazabou
Copy link
Member

mazabou commented Nov 4, 2024

What is the use case for this? @vinamarora8 @AlexandreAndr

Technically this behavior can be achieved by changing the interval_dict to have intervals with the exact same length of the desired trial, that way there won't be any jitter.

@AlexandreAndr
Copy link
Contributor Author

I think I get it.
Do you mean if we have window_length that has the same length as the intervals in interval_dict, doesn't it apply a jiter?

@AlexandreAndr AlexandreAndr deleted the aandre/no_jitter_random_sampling branch November 8, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants