-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4] Clean train config by using hydra config overriding #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinamarora8
changed the title
Clean train config by using hydra config overriding
[4] Clean train config by using hydra config overriding
Oct 12, 2024
mazabou
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hydra allows us to have a base config and override it with another config on top. We can use this for POYO where we have a mostly stable base config, and each different training target overrides/adds only some fields. Having a base config means we can add default config fields later without breaking any dataset-specific configs.
Also, use of proper hierarchies in base config cleans it up. Example:
This PR adds
base.yaml
which is inherited bytrain_poyo_mp.yaml
,train_allen_neuropixels.yaml
,train_mc_maze_small.yaml
. Does not update other configs as they don't work as it is with current code.