Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Cython extensions out-of-source #3302

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Jan 7, 2025

Follow-up on #2662.
According to this SO answer, we can add an attribute to the Cython Extension to make it generate the c file out-of-source.
Also removes an unused setup.py.in file.

Copy link

✔️ c6fa345 -> Azure artifacts URL

@JCGoran JCGoran marked this pull request as ready for review January 8, 2025 13:28
@JCGoran JCGoran requested a review from nrnhines January 8, 2025 13:29
@JCGoran JCGoran added cython building Issue related to build/compilation rxd reaction-diffusion labels Jan 8, 2025
Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what's going on behind the scenes, but it works :) . I see that the files end up in

temp$ find . -name ctng.c
./build/share/lib/python/neuron/rxd/geometry3d/ctng.c

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (d68acad) to head (5a81903).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3302   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         571      571           
  Lines      111055   111055           
=======================================
  Hits        74488    74488           
  Misses      36567    36567           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ 5a81903 -> Azure artifacts URL

@JCGoran JCGoran merged commit 9500741 into master Jan 8, 2025
44 of 47 checks passed
@JCGoran JCGoran deleted the jelic/cythonize-in-build2 branch January 8, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Issue related to build/compilation cython rxd reaction-diffusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants