-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Cython extensions out-of-source #3302
Conversation
✔️ c6fa345 -> Azure artifacts URL |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know what's going on behind the scenes, but it works :) . I see that the files end up in
temp$ find . -name ctng.c
./build/share/lib/python/neuron/rxd/geometry3d/ctng.c
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3302 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 571 571
Lines 111055 111055
=======================================
Hits 74488 74488
Misses 36567 36567 ☔ View full report in Codecov by Sentry. |
✔️ 5a81903 -> Azure artifacts URL |
Follow-up on #2662.
According to this SO answer, we can add an attribute to the Cython
Extension
to make it generate thec
file out-of-source.Also removes an unused
setup.py.in
file.