Skip to content

Commit

Permalink
fix: NVSHAS-9662 fix inconsistent role bindings
Browse files Browse the repository at this point in the history
Remove a few role bindings when internal.autoGenerateCert is disabled
  • Loading branch information
holyspectral authored and venkateshjayagopal committed Jan 7, 2025
1 parent 563a95d commit d5e8db3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/core/templates/rolebinding-least.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ subjects:
userNames:
- system:serviceaccount:{{ .Release.Namespace }}:controller
{{- end }}
{{- end }}
---
{{- if $oc3 }}
apiVersion: authorization.openshift.io/v1
Expand Down Expand Up @@ -128,6 +127,7 @@ subjects:
userNames:
- system:serviceaccount:{{ .Release.Namespace }}:cert-upgrader
{{- end }}
{{- end }}
---
{{- if $oc3 }}
apiVersion: authorization.openshift.io/v1
Expand Down
2 changes: 1 addition & 1 deletion charts/core/templates/rolebinding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ subjects:
- kind: ServiceAccount
name: {{ .Values.serviceAccount }}
namespace: {{ .Release.Namespace }}
{{- end }}
---
{{- if $oc3 }}
apiVersion: authorization.openshift.io/v1
Expand Down Expand Up @@ -170,4 +169,5 @@ userNames:
- system:serviceaccount:{{ .Release.Namespace }}:cert-upgrader
{{- end }}
{{- end }}
{{- end }}

0 comments on commit d5e8db3

Please sign in to comment.