Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.5 chart refactor #269

Closed

Conversation

frank-at-suse
Copy link
Contributor

Update NeuVector Helm chart to be more usable:

  • Eliminate nested YAML documents by exposing *initcfg.yaml files top-level values. This will take the YAML formatting burden away from the chart consumer and make previously buried settings able to be consumed via Helm CLI install if desired (i.e. --set systemSettings.autoScan=true or --set monitoring.enabled=true)
  • Address several (minor) open issues and PRs regarding exposed/configurable values, such as:
    K3s/RKE note in values.yaml #266
    feat: expose the imagePullPolicy parameter for every container as a Helm value #246
    and also other various install issues vocalized in community Slack and within Suse.
  • Pare down values in README.md so it's less intimidating to a new user. Also added links to docs site, install guide, troubleshooting section, etc.
  • Eliminate separate 'monitor' chart in favor of slipstreaming those manifests into the 'core' chart and enabling/exposing those settings in values.yaml. This means one less chart to maintain/version and makes monitoring of NV core components more available and consumable (also addressing community request).

@garyduan
Copy link
Contributor

garyduan commented Jun 8, 2023

This PR need rework because variable name changes will cause backward compatibility issue. The PR will also have conflicts with least-priv branch. We suggest to break the PR down into multiple small PRs.

@garyduan garyduan closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants