feat: Added New Relic Control health check #2841
Draft
+644
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2841 +/- ##
==========================================
- Coverage 97.26% 97.22% -0.04%
==========================================
Files 294 295 +1
Lines 46405 46625 +220
==========================================
+ Hits 45135 45333 +198
- Misses 1270 1292 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bizob2828
reviewed
Jan 7, 2025
| static STATUS_INTERNAL_UNEXPECTED_ERROR = 'NR-APM-300' | ||
|
|
||
| constructor({ logger = defaultLogger, setInterval = global.setInterval } = {}) { | ||
| const fleetId = process.env.NEW_RELIC_SUPERAGENT_FLEET_ID |
There was a problem hiding this comment.
these should be configuration items, based on spec, and names appear to be updated to be agent_control not superagent:
| Name | Environment Variable Name | Description | Default | Required? |
|---|---|---|---|---|
| agent_control.fleet_id | NEW_RELIC_AGENT_CONTROL_FLEET_ID | This assigns a fleet ID to the language agent. This ID is generated by Agent Control. If this setting is present, it denotes that the agent is running in an Agent Control environment and the health file(s) will be generated. | n/a | MUST |
| agent_control.health.delivery_location | NEW_RELIC_AGENT_CONTROL_HEALTH_DELIVERY_LOCATION | A file: URI that specifies the fully qualified directory path for health file(s) to be written to. For example: file:///var/lib/newrelic-agent_control/fleet/agents.d/<fleet_id> |
N/A | MUST |
| agent_control.health.frequency | NEW_RELIC_AGENT_CONTROL_HEALTH_FREQUENCY | The interval, in seconds, of how often the health file(s) will be written. | 5 | MUST |
There was a problem hiding this comment.
It looks like we do load the config before creating the agent. So adding in support for those config values will be feasible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2838.