Step3 #3251
Open
Step3 #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyeon9mak
requested changes
May 23, 2023
| import java.util.Scanner; | ||
|
|
||
| public class BonusBallInputView implements InputView<BonusBall> { | ||
| Scanner scanner = new Scanner(System.in); |
There was a problem hiding this comment.
기찬님 견해가 궁금합니다!
There was a problem hiding this comment.
매번 새로운 인스턴스를 생성하는 건 비효율적인 것 같네요
생성자에서 입력받아 사용하도록 바꿀게요!
Comment on lines
+14
to
15
|
|
||
| public static List<Lottery> buy(Integer price, LotteryStrategy lotteryStrategy) { |
There was a problem hiding this comment.
로또금액을 VO 로 포장하면 더 신뢰할 수 있는 값이 되겠네요.
Comment on lines
+10
to
+12
| public LotteryNumber value() { | ||
| return value; | ||
| } |
There was a problem hiding this comment.
더욱 더 VO 스럽게 사용하기 위해 동등성을 부여해주면 어떨까요? (equals & hash code)
Comment on lines
3
to
9
| public enum WinPrize { | ||
| FIRST_PLACE(2000000000), | ||
| SECOND_PLACE(1500000), | ||
| THIRD_PLACE(50000), | ||
| FOURTH_PLACE(5000), | ||
| SECOND_PLACE(30000000), | ||
| THIRD_PLACE(1500000), | ||
| FOURTH_PLACE(50000), | ||
| FIFTH_PLACE(5000), | ||
| LOST(0); |
There was a problem hiding this comment.
enum 을 통해서 상금과 당첨 개수, 보너스볼 여부도 관리해볼 수 있을까요? 🤔
Comment on lines
31
to
37
| List<Integer> winLotteryNumbers = new ArrayList<>(); | ||
| for (int i = 0; i <= Lottery.LENGTH; i++) { | ||
| for (int i = 0; i < RANK_LENGTH; i++) { | ||
| winLotteryNumbers.add(0); | ||
| } | ||
| for (int number : numberOfMatchNumbers) { | ||
| winLotteryNumbers.set(number, winLotteryNumbers.get(number) + 1); | ||
| for (int i = 0; i < numberOfMatchNumbers.size(); i++) { | ||
| checkBonusBallAndAdd(hasBonusBalls.get(i), numberOfMatchNumbers.get(i), winLotteryNumbers); | ||
| } |
There was a problem hiding this comment.
각 반복문의 의미를 잘 모르겠어요 😢 메서드로 분리하고 메서드 이름을 통해 의미를 부여해줄 수 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step3 2등 추가 요구사항 추가하였습니다!