Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix - TaskProcessingAPI #1624

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Jan 9, 2025

Copy link
Contributor

github-actions bot commented Jan 9, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky
Copy link
Member

Does this need a client change?
If so there is a label for it, so that we do not merge it.

@tobiasKaminsky
Copy link
Member

CI test also fails now

@alperozturk96
Copy link
Contributor Author

Does this need a client change? If so there is a label for it, so that we do not merge it.

Yes, client also needs to adopt these changes.

@alperozturk96
Copy link
Contributor Author

CI test also fails now

I will check it

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the bugfix/task-processing-response branch from e0cee66 to 874915d Compare January 10, 2025 13:29
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 22.91%. Comparing base (a63f9f2) to head (874915d).

Files with missing lines Patch % Lines
...rces/assistant/v2/GetTaskTypesRemoteOperationV2.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1624      +/-   ##
============================================
- Coverage     22.91%   22.91%   -0.01%     
  Complexity      618      618              
============================================
  Files           215      215              
  Lines          8177     8173       -4     
  Branches       1040     1040              
============================================
- Hits           1874     1873       -1     
+ Misses         6123     6119       -4     
- Partials        180      181       +1     
Files with missing lines Coverage Δ
...roid/lib/resources/assistant/v2/model/TaskTypes.kt 93.75% <100.00%> (+6.25%) ⬆️
...rces/assistant/v2/GetTaskTypesRemoteOperationV2.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants