Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP and XML linters #72

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Add PHP and XML linters #72

merged 1 commit into from
Nov 2, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 31, 2022 •
edited
Loading

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews enhancement New feature or request labels Oct 31, 2022
@ChristophWurst ChristophWurst requested a review from st3iny October 31, 2022 13:58
@ChristophWurst ChristophWurst self-assigned this Oct 31, 2022
@ChristophWurst
Copy link
Member Author

There are no checks for this commit

(x) doubt

@ChristophWurst ChristophWurst mentioned this pull request Oct 31, 2022
Closed
9 tasks
miaulalala
miaulalala approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but why the XML linter?

@ChristophWurst
Copy link
Member Author

It's not necessary for PHP8.2 but we do lint the info.xml in other apps as well. It allows us to catch xml schema violations before a release. Because the app store might reject some markup.

@ChristophWurst
Add PHP and XML linters
bdd00e0 
Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the enhancement/php-xml-lint branch from abe3f64 to bdd00e0 Compare November 2, 2022 07:57
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2022
@ChristophWurst ChristophWurst merged commit 1f9bf11 into main Nov 2, 2022
@ChristophWurst ChristophWurst deleted the enhancement/php-xml-lint branch November 2, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@st3iny st3iny Awaiting requested review from st3iny st3iny is a code owner

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @miaulalala