-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: Show confirmation dialog before submitting an empty form #1803
Conversation
Signed-off-by: Ferdinand Thiessen <[email protected]>
c1248a1
to
2d37ba2
Compare
Was on vacation last week so only saw this now, some late design feedback @susnux :)
|
Indeed the confirm modal looks strange. @susnux any idea why? |
As written in the initial post the padding is caused by a component bug fixed in nextcloud vue 8.3 |
all right, thanks! :) |
Ok will change this , thank you for the feedback :) |
Awesome @susnux, and sorry for missing your remark in the original post! :) |
When submitting and empty form a confirmation dialog is shown, to make sure users submitted willingly an empty form.
Also please note the missing padding of the text in the dialog will be fixed with the next nextcloud-vue update (is a component bug not related to this PR).
vokoscreenNG-2023-11-28_21-29-30.mp4
Note: This can not be backported due to missing NcDialog in nextcloud-vue 7.