Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Question): Do not place popover within question but on body #1849

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Dec 24, 2023

Fix #1840

Fix the placement of the popover and remove unneeded styles.

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Dec 24, 2023
@susnux susnux requested a review from Chartman123 December 24, 2023 01:01
@susnux
Copy link
Collaborator Author

susnux commented Dec 24, 2023

Is a backport needed for v3?

@Chartman123
Copy link
Collaborator

I don't know, I currently don't have a test/dev instance anymore... But I could spin one up in the next few days

@Chartman123
Copy link
Collaborator

Chartman123 commented Dec 24, 2023

Is a backport needed for v3?

@susnux I thought about it and probably won't hurt there, so I think we should just backport it? However it's not that relevant there, as the menu is missing the copy question action that won't be backported.

@Chartman123 Chartman123 merged commit 99e60d7 into main Dec 24, 2023
34 checks passed
@Chartman123 Chartman123 deleted the fix/actions-button branch December 24, 2023 10:09
@susnux
Copy link
Collaborator Author

susnux commented Dec 26, 2023

/backport to stable3

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Dec 26, 2023
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question menu overlayed by three dot menu button
2 participants