Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: Show more informative buttons when selecting CSV file location #1854

Merged
merged 1 commit into from
Jan 4, 2024
Merged

enh: Show more informative buttons when selecting CSV file location #1854

merged 1 commit into from
Jan 4, 2024

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Dec 26, 2023 •
edited
Loading

  • Show visual error toast to user when there was something not working instead of only showing a browser console debug message
  • Some general refactoring
  • Show more informative buttons, see below

before

vokoscreenNG-2023-12-26_19-33-29.mp4

after

vokoscreenNG-2023-12-26_19-35-18.mp4

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews labels Dec 26, 2023
@susnux susnux added this to the 4.1 milestone Dec 26, 2023
Chartman123
Chartman123 reviewed Dec 26, 2023
View reviewed changes
src/views/Results.vue Outdated Show resolved Hide resolved
Chartman123
Chartman123 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the little comment about the JSDoc description, rest seems fine 👍🏻

jancborchardt
jancborchardt approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gopd design-wise :)

@susnux susnux force-pushed the enh/file-picker-buttons branch from 46f670a to bdf6454 Compare January 4, 2024 14:44
@susnux susnux force-pushed the enh/file-picker-buttons branch from bdf6454 to 977f4ee Compare January 4, 2024 14:44
@susnux susnux merged commit 3d19e39 into main Jan 4, 2024
34 checks passed
@susnux susnux deleted the enh/file-picker-buttons branch January 4, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chartman123 Chartman123 Chartman123 approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @jancborchardt @Chartman123