Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow listening to form submissions via events and webhooks #2265

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

marcelklehr
Copy link
Member

requires Nextcloud 30

This will allow users of the upcoming windmill workflow automation app to trigger automations based on form submissions.

@marcelklehr marcelklehr requested review from Koc and susnux August 6, 2024 09:42
@marcelklehr marcelklehr force-pushed the feat/webhooks branch 2 times, most recently from 68adead to ba50b71 Compare August 6, 2024 10:34
@susnux susnux added the 2. developing Work in progress label Aug 6, 2024
@Chartman123 Chartman123 added enhancement New feature or request integration Compatibility with other apps/systems labels Aug 6, 2024
@Chartman123 Chartman123 added this to the 5.0 milestone Aug 6, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6b0f960). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2265   +/-   ##
=======================================
  Coverage        ?   36.16%           
  Complexity      ?     1014           
=======================================
  Files           ?       70           
  Lines           ?     3824           
  Branches        ?        0           
=======================================
  Hits            ?     1383           
  Misses          ?     2441           
  Partials        ?        0           

@susnux
Copy link
Collaborator

susnux commented Aug 7, 2024

requires Nextcloud 30

So this can only be part of the next planned major version 5.0 as we still support Nextcloud 29 an 28, while there are already plans for 5.0 we still need to work on some features / technical dept.

@marcelklehr marcelklehr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 9, 2024
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice side effect: We can use this for flow support besides windmill :)

@marcelklehr marcelklehr force-pushed the feat/webhooks branch 2 times, most recently from eaa4ba9 to eab4d7d Compare September 3, 2024 10:29
@marcelklehr
Copy link
Member Author

I removed the requirement of Nextcloud 30, so we can hopefully merge this sooner 🙏

@Chartman123
Copy link
Collaborator

@marcelklehr nice :) please fix the errors, then we can merge it :)

@Chartman123 Chartman123 modified the milestones: 5.0, 4.3 Sep 3, 2024
@Chartman123 Chartman123 merged commit 75192da into nextcloud:main Sep 3, 2024
50 checks passed
@Chartman123
Copy link
Collaborator

@come-nc @marcelklehr Can this be used to solve issues #1850, #1772, #1748, #1223 and/or #805?

@susnux
Copy link
Collaborator

susnux commented Sep 17, 2024

Yes and no, this is about windmill webhooks based workflows.
That allows to do even more than with Nextcloud flow but requires you to also host Windmill, so this is nothing that can be easily done on "plain" hosting.

Meaning the first 3 issues would I still consider feature requests, similar to the analytics integration - if someone wants to create an integration (and add proper tests) we could integrate that.
The last one ... well the new windmill integration is called "flow" but that ticket is more about workflowengine flow which is the Nextcloud built-in alternative that does not require external API, maybe still something to consider but would also need work on our side.

only #1223 could be done with Nextcloud 30 due to the webhook_listeners app integrated with Nextcloud now.
You should be able to register webhooks based on the forms submitted event. I did not test this yet, but probably something we could document and then close the request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request integration Compatibility with other apps/systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants