Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding and max width so they don't stick to right screen border #2400

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

Elsensee
Copy link
Contributor

@Elsensee Elsensee commented Nov 6, 2024

This also aligns them

Before: (notice how the border isn't clearly visible because it sticks to the right screen border)
Screenshot 2024-11-06 at 17-00-31 TEST - Formulare - Storage Share
Screenshot 2024-11-06 at 17-00-18 TEST - Formulare - Storage Share

After:
Screenshot 2024-11-06 at 16-53-17 TEST - Formulare - Storage Share
Screenshot 2024-11-06 at 16-59-57 TEST - Formulare - Storage Share

The german translation text doesn’t fit completely into the text box when the screen is very small. It will fit however into the max-width of 300px.

@Chartman123 Chartman123 added enhancement New feature or request design Related to the design 3. to review Waiting for reviews labels Nov 6, 2024
@Chartman123
Copy link
Collaborator

Hi @Elsensee and thanks for your contribution :) Looks good from my side.

While checking your changes, I realized that our layout is currently also a little bit broken on normal screens. If you want, you can also give it a try and fix our CSS to align all elements (especially in the create/edit view)

@Chartman123 Chartman123 added this to the 4.3.3 milestone Nov 7, 2024
@Chartman123
Copy link
Collaborator

/backport to stable4

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Nov 7, 2024
@Chartman123 Chartman123 modified the milestones: 4.3.3, 5.0 Nov 7, 2024
@Elsensee
Copy link
Contributor Author

Elsensee commented Nov 7, 2024

@Chartman123 Great!

I might get to it this weekend. :)

@Elsensee
Copy link
Contributor Author

Elsensee commented Nov 8, 2024

While checking your changes, I realized that our layout is currently also a little bit broken on normal screens. If you want, you can also give it a try and fix our CSS to align all elements (especially in the create/edit view)

To be honest, I'm not quite sure what you mean. It looks fine and aligned to me? Or maybe I am looking in the wrong place.

@Chartman123
Copy link
Collaborator

Chartman123 commented Nov 8, 2024

@Elsensee I'll create a new issue with some screenshots :)

Update: see created issue #2403

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice to me, thank you for the fix @Elsensee! :) Looking forward to further contributions if you like!

@Chartman123 Chartman123 merged commit ec712fc into nextcloud:main Nov 11, 2024
43 checks passed
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Nov 11, 2024
@Elsensee Elsensee deleted the fix-submit-css branch December 7, 2024 22:59
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to the design enhancement New feature or request feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants