-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add padding and max width so they don't stick to right screen border #2400
Conversation
Also make them align Signed-off-by: Oliver Schramm <[email protected]>
c6c4b4f
to
b46f7ca
Compare
Hi @Elsensee and thanks for your contribution :) Looks good from my side. While checking your changes, I realized that our layout is currently also a little bit broken on normal screens. If you want, you can also give it a try and fix our CSS to align all elements (especially in the create/edit view) |
/backport to stable4 |
@Chartman123 Great! I might get to it this weekend. :) |
To be honest, I'm not quite sure what you mean. It looks fine and aligned to me? Or maybe I am looking in the wrong place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice to me, thank you for the fix @Elsensee! :) Looking forward to further contributions if you like!
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This also aligns them
Before: (notice how the border isn't clearly visible because it sticks to the right screen border)
After:
The german translation text doesn’t fit completely into the text box when the screen is very small. It will fit however into the
max-width
of 300px.