Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation problem in notifications #2447

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

Chartman123
Copy link
Collaborator

This fixes #2434

@Chartman123 Chartman123 added bug Something isn't working 3. to review Waiting for reviews language l10n and translations labels Dec 6, 2024
@Chartman123 Chartman123 added this to the 5.0 milestone Dec 6, 2024
@Chartman123
Copy link
Collaborator Author

/backport to stable4

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Dec 6, 2024
@Chartman123 Chartman123 force-pushed the fix/notification-text branch from f9938d5 to 2caf5f3 Compare December 6, 2024 10:49
@susnux
Copy link
Collaborator

susnux commented Dec 6, 2024

/home/runner/actions-runner/_work/forms/forms/apps/forms/tests/Unit/Activity/ProviderTest.php:205

Related failure

@Chartman123 Chartman123 force-pushed the fix/notification-text branch from 2caf5f3 to 6a3a07d Compare December 6, 2024 10:52
@Chartman123
Copy link
Collaborator Author

/home/runner/actions-runner/_work/forms/forms/apps/forms/tests/Unit/Activity/ProviderTest.php:205

Related failure

Yes, I fixed the tests now as well :)

@Chartman123 Chartman123 force-pushed the fix/notification-text branch from 6a3a07d to 70a3a3c Compare December 6, 2024 10:54
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@2f2ae8c). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2447   +/-   ##
=======================================
  Coverage        ?   44.27%           
  Complexity      ?      860           
=======================================
  Files           ?       73           
  Lines           ?     3268           
  Branches        ?        0           
=======================================
  Hits            ?     1447           
  Misses          ?     1821           
  Partials        ?        0           

@Chartman123 Chartman123 merged commit 08ed327 into main Dec 6, 2024
48 checks passed
@Chartman123 Chartman123 deleted the fix/notification-text branch December 6, 2024 10:59
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working language l10n and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submission notification email needs a plural form as multiple users can be present in {user}
3 participants