feat: integration of unified search

[Chartman123]

This closes #2392 by implementing a SearchProvider that let's you search the titles and descriptions of the forms that are available to you.

[codecov]

Codecov Report

Attention: Patch coverage is 13.33333% with 65 lines in your changes missing coverage. Please review.

Project coverage is 43.53%. Comparing base (c2c3c31) to head (07aecc9).
Report is 8 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2479      +/-   ##
============================================
- Coverage     44.27%   43.53%   -0.75%     
- Complexity      859      870      +11     
============================================
  Files            73       75       +2     
  Lines          3268     3331      +63     
============================================
+ Hits           1447     1450       +3     
- Misses         1821     1881      +60     

[Chartman123]

@hamza221 It's basically working, but apparently it doesn't return all matching forms. Perhaps you can find some time and have a look

[Chartman123]

@hamza221 I found the culprit: I used a simple like-operation for the DB query instead of the case insensitive iLike :)

[hamza221]

I spent an hour on this and I'm ,not sure what's happening. I'm sure I'm missing something obvious
The shared search is not working for me (when I remove the lines you added it returns all shared as expected)
your code looks correct but checking the db logs I found this
my search term is %adham%

SELECT * FROM oc_forms_v2_forms WHERE ( id IN ( SELECT DISTINCT forms.id FROM oc_forms_v2_forms forms LEFT JOIN oc_forms_v2_shares shares ON forms.id = shares.form_id WHERE ( ( (shares.share_type = '0' AND shares.share_with = 'admin') OR (shares.share_type = '1' AND shares.share_with IN ('admin')) ) OR (access_enum IN (2)) ) AND forms.owner_id <> 'admin' ) ) AND ( title COLLATE utf8mb4_general_ci LIKE '0' OR description COLLATE utf8mb4_general_ci LIKE 'admin' ) ORDER BY last_updated DESC, created DESC;

See how the like value is wrong
Compared to the owned forms search 👇

SELECT * FROM oc_forms_v2_forms WHERE (owner_id = 'admin') AND (title COLLATE utf8mb4_general_ci LIKE '%adham%' OR description COLLATE utf8mb4_general_ci LIKE '%adham%') ORDER BY last_updated DESC, created DESC;

[Chartman123]

Ok, I found the error:

forms/lib/Db/FormMapper.php

Line 166 in f69a116

$qbForms->setParameters($qbShares->getParameters(), $qbShares->getParameterTypes());

We set the parameters from qbShares to be the parameters of qbForms. So they get mixed up when I set the new parameters for the search...

[hamza221]

Works ✅