Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: only show confirmation dialog for active forms #2504

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

Chartman123
Copy link
Collaborator

This fixes #2503 by checking if the form is active

@Chartman123 Chartman123 added bug Something isn't working 2. developing Work in progress labels Jan 20, 2025
@Chartman123 Chartman123 self-assigned this Jan 20, 2025
@Chartman123 Chartman123 added this to the 5.0 milestone Jan 20, 2025
@Chartman123 Chartman123 force-pushed the fix/leave-inactive-form branch from 0e84add to 9905534 Compare January 20, 2025 10:43
@Chartman123 Chartman123 marked this pull request as ready for review January 20, 2025 10:58
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 20, 2025
@Chartman123 Chartman123 requested a review from susnux January 20, 2025 10:58
src/views/Submit.vue Outdated Show resolved Hide resolved
@Chartman123 Chartman123 force-pushed the fix/leave-inactive-form branch from 9905534 to c8bbc63 Compare January 20, 2025 11:52
@Chartman123 Chartman123 requested a review from susnux January 20, 2025 12:04
@Chartman123 Chartman123 merged commit 2b749bf into main Jan 20, 2025
47 checks passed
@Chartman123 Chartman123 deleted the fix/leave-inactive-form branch January 20, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaving a closed form triggers warning
2 participants