-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: file conversion provider #4375
Merged
Merged
+246
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
force-pushed
the
feat/file-conversion-provider
branch
2 times, most recently
from
January 16, 2025 21:28
6ef2383
to
2cf6f46
Compare
juliusknorr
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one additional comment regarding formats.
elzody
force-pushed
the
feat/file-conversion-provider
branch
from
January 21, 2025 18:41
7b8730d
to
cc1b9f2
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
force-pushed
the
feat/file-conversion-provider
branch
from
January 21, 2025 19:40
cc1b9f2
to
2d14c5d
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
added
3. to review
Ready to be reviewed
and removed
2. developing
Work in progress
labels
Jan 21, 2025
/backport to stable31 |
blizzz
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skimmed it, did not spot anything weird (but also did not spot tests 🤐)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To test file conversion, send a network request like the following:
TODO
Testing will probably be in a follow-up PR.
Checklist