Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: file conversion provider #4375

Merged
merged 3 commits into from
Jan 23, 2025
Merged

feat: file conversion provider #4375

merged 3 commits into from
Jan 23, 2025

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Jan 8, 2025

Summary

To test file conversion, send a network request like the following:

curl --request POST \
  --url 'http://nextcloud.local/ocs/v2.php/apps/files/api/v1/convert?format=json' \
  --header 'Authorization: Basic YWRtaW46YWRtaW4=' \
  --header 'Content-Type: application/json' \
  --header 'ocs-apirequest: true' \
  --data '{
  "fileId": 1337,
  "targetMimeType": "target/mime+type"
}'

TODO

Testing will probably be in a follow-up PR.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@elzody elzody self-assigned this Jan 8, 2025
@elzody elzody added enhancement New feature or request 2. developing Work in progress labels Jan 8, 2025
@elzody elzody force-pushed the feat/file-conversion-provider branch 2 times, most recently from 6ef2383 to 2cf6f46 Compare January 16, 2025 21:28
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one additional comment regarding formats.

lib/Conversion/ConversionProvider.php Show resolved Hide resolved
@elzody elzody force-pushed the feat/file-conversion-provider branch from 7b8730d to cc1b9f2 Compare January 21, 2025 18:41
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody elzody force-pushed the feat/file-conversion-provider branch from cc1b9f2 to 2d14c5d Compare January 21, 2025 19:40
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody elzody changed the title Feat/file conversion provider feat: file conversion provider Jan 21, 2025
@elzody elzody marked this pull request as ready for review January 21, 2025 20:01
@elzody elzody requested a review from juliusknorr January 21, 2025 20:01
@elzody elzody added 3. to review Ready to be reviewed and removed 2. developing Work in progress labels Jan 21, 2025
@elzody
Copy link
Contributor Author

elzody commented Jan 23, 2025

/backport to stable31

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed it, did not spot anything weird (but also did not spot tests 🤐)

@elzody elzody merged commit db406db into main Jan 23, 2025
73 of 74 checks passed
@elzody elzody deleted the feat/file-conversion-provider branch January 23, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed enhancement New feature or request
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants