Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test PHP 8.2 through CI #32463

Closed
wants to merge 15 commits into from
Closed

Test PHP 8.2 through CI #32463

wants to merge 15 commits into from

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented May 17, 2022 •
edited by ChristophWurst
Loading

The point of this PR is to test master with PHP 8.2 nightly/beta builds.
Fix for the problems found should go in other PRs, and this one can be rebased on master to validate.

I may remove non-relevant CI from the branch to speed things up.

Signed-off-by: Côme Chilliet [email protected]

Contributes to #32595

@come-nc come-nc self-assigned this May 17, 2022
@come-nc come-nc added php Pull requests that update Php code do not merge labels May 17, 2022
@come-nc come-nc force-pushed the fix/test-php-8.2 branch from 9e77e88 to 16a847e Compare June 13, 2022 09:35
@come-nc
Copy link
Contributor Author

come-nc commented Jun 16, 2022

/rebase

@come-nc
Copy link
Contributor Author

come-nc commented Jun 21, 2022

/rebase

@PVince81
Copy link
Member

let's try to group the things that need fixing into issues, for the easy ones set the label "good first issue"
for the tricky / urgent ones, we can discuss if we want to do them right away

@come-nc
Copy link
Contributor Author

come-nc commented Jun 28, 2022

/rebase

@come-nc come-nc mentioned this pull request Aug 1, 2022
Closed
19 tasks
@come-nc
Copy link
Contributor Author

come-nc commented Aug 2, 2022

/rebase

@come-nc
Copy link
Contributor Author

come-nc commented Sep 5, 2022

/rebase

@come-nc
Copy link
Contributor Author

come-nc commented Sep 8, 2022

/rebase

@come-nc come-nc mentioned this pull request Nov 7, 2022
Closed
@come-nc come-nc mentioned this pull request Nov 14, 2022
Merged
@come-nc
Copy link
Contributor Author

come-nc commented Nov 14, 2022 

There were 271 errors:

(Some are false-positive)

@come-nc
Copy link
Contributor Author

come-nc commented Nov 14, 2022

#34819 should help

@come-nc
Copy link
Contributor Author

come-nc commented Nov 15, 2022

/rebase

@come-nc
Copy link
Contributor Author

come-nc commented Nov 15, 2022 

There were 271 errors:

(Some are false-positive)

There were 119 errors:

20 are also there on 8.1 so are false positives.

@come-nc
Copy link
Contributor Author

come-nc commented Nov 15, 2022

Opened sebastianbergmann/phpunit#5099 on phpunit to figure out how to fix apps/oauth2/tests/Controller/OauthApiControllerTest.php

@come-nc come-nc mentioned this pull request Nov 15, 2022
Merged
@come-nc
Copy link
Contributor Author

come-nc commented Nov 15, 2022

/rebase

@come-nc
Copy link
Contributor Author

come-nc commented Nov 15, 2022

  • mysql/8.1 Tests: 14461, Assertions: 37167, Errors: 14, Failures: 7, Warnings: 168, Skipped: 130.
    1532
  • mysql/8.2 Tests: 14461, Assertions: 35960, Errors: 100, Failures: 89, Warnings: 149, Skipped: 130.
    3159
  • sqlite/8.2 Tests: 14461, Assertions: 35960, Errors: 100, Failures: 89, Warnings: 149, Skipped: 130.
    3161

@come-nc
Copy link
Contributor Author

come-nc commented Nov 22, 2022

  • mysql/8.1 Tests: 14461, Assertions: 37167, Errors: 14, Failures: 7, Warnings: 168, Skipped: 130.
    1532
  • mysql/8.2 Tests: 14461, Assertions: 35960, Errors: 100, Failures: 89, Warnings: 149, Skipped: 130.
    3159
  • sqlite/8.2 Tests: 14461, Assertions: 35960, Errors: 100, Failures: 89, Warnings: 149, Skipped: 130.
    3161
  • mysql/8.1 Tests: 14461, Assertions: 37168, Errors: 14, Failures: 7, Warnings: 168, Skipped: 130.
    1532
  • mysql/8.2 Tests: 14461, Assertions: 35966, Errors: 99, Failures: 89, Warnings: 149, Skipped: 130.
    3147
  • sqlite/8.2 Tests: 14461, Assertions: 35965, Errors: 99, Failures: 89, Warnings: 149, Skipped: 130.
    3149

Only one error fixed :-(

@come-nc
Copy link
Contributor Author

come-nc commented Nov 28, 2022

/rebase

@come-nc
Copy link
Contributor Author

come-nc commented Nov 28, 2022

  • mysql/8.1 Tests: 14461, Assertions: 37167, Errors: 14, Failures: 7, Warnings: 168, Skipped: 130.
    1532
  • mysql/8.2 Tests: 14461, Assertions: 35960, Errors: 100, Failures: 89, Warnings: 149, Skipped: 130.
    3159
  • sqlite/8.2 Tests: 14461, Assertions: 35960, Errors: 100, Failures: 89, Warnings: 149, Skipped: 130.
    3161
  • mysql/8.1 Tests: 14461, Assertions: 37168, Errors: 14, Failures: 7, Warnings: 168, Skipped: 130.
    1532
  • mysql/8.2 Tests: 14461, Assertions: 35966, Errors: 99, Failures: 89, Warnings: 149, Skipped: 130.
    3147
  • sqlite/8.2 Tests: 14461, Assertions: 35965, Errors: 99, Failures: 89, Warnings: 149, Skipped: 130.
    3149

Only one error fixed :-(

  • mysql/8.1 Tests: 14465, Assertions: 37184, Errors: 13, Failures: 7, Warnings: 168, Skipped: 130.
    1526
  • mysql/8.2 Tests: Tests: 14465, Assertions: 36344, Errors: 75, Failures: 99, Warnings: 150, Skipped: 130.
    2896

@come-nc
Copy link
Contributor Author

come-nc commented Dec 19, 2022

rebased

@come-nc
Copy link
Contributor Author

come-nc commented Jan 23, 2023

(rebased)

come-nc added 15 commits January 26, 2023 09:49
@come-nc
Add 8.2 lint and phpunit
db0b8f5 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Empty drone config and adapt phpunit workflow
fe4ef17 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Try to fix phpunit installation
77c7b5e 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Fix port and mariadb detection
99d83a0 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Allow 8.2 in versioncheck
4a46eb0 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Run phpunit from correct folder
dc28cb7 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Add sqlite testing, add php --version to check used version
75bbbd0 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Remove unrelevant workflows, add a custom one
056185c 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Some tests with custom workflow
29cb7b9 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Use development ini file to get deprecation warnings
974c60e 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Clean up
03155b0 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Remove node workflows and use 8.2 for performance workflow
f10a11f 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Use old ubuntu
4ef6f3b 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Install extension pcntl for tests
db080c2 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Attempt at fixing pcntl in tests
9058401 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc mentioned this pull request Feb 2, 2023
Merged
@come-nc come-nc closed this Jun 26, 2023
@skjnldsv skjnldsv deleted the fix/test-php-8.2 branch March 14, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@come-nc come-nc

Labels
php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @PVince81 @nickvergessen