feat: Make it possible to customize share link tokens #49317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
force-pushed
the
feat/edit-share-token
branch
from
948ea93 to
5578770
Compare
Pytal
changed the title
Pytal
force-pushed
the
feat/edit-share-token
branch
from
5578770 to
f57a605
Compare
Pytal
added
3. to review
provokateurin
requested changes
Dec 17, 2024
| <NcInputField v-if="config.allowCustomTokens && isPublicShare && !isNewShare" | ||
| autocomplete="off" | ||
| :label="t('files_sharing', 'Share link token')" | ||
| :helper-text="t('files_sharing', 'Set the public share link token to something easy to remember or generate a new token. It is not recommended to use a guessable token for shares which contain sensitive information.')" |
There was a problem hiding this comment.
@nextcloud/designers what do you think about this message? I think we should have something better that doesn't first incentivize using something easy and then reverting that in the second sentence
Pytal
force-pushed
the
feat/edit-share-token
branch
from
f57a605 to
14bea75
Compare
provokateurin
requested changes
Jan 6, 2025
Merged
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
feat/edit-share-token
branch
from
14bea75 to
6bcbc5a
Compare
Pytal
force-pushed
the
feat/edit-share-token
branch
2 times, most recently
from
7d45364 to
3801197
Compare
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
feat/edit-share-token
branch
from
3801197 to
a89f31d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist