Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): File conversion Files action #50123

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 10, 2025

Peek.22-01-2025.09-22.mp4

How-to

  1. Enable the testing app
  2. Go check a folder you have with a jpeg
  3. Click the actions menu
  4. Click Save as and select the desired format
  5. Wait for conversion

Explanations

Q. Why are we not using the default loading indicator
A. Conversion is kind of a background process, we wanna let the user keep using files while they happen in the background. That includes do other actions, which are disabled if we use the default loading indicator (marking the entire node as loading). The loader notification is permanent and will only remove itself on completion (error or success)

Followups

  • Prevent page unload if the queue is still processing
  • Fix scrolling on conversion

@skjnldsv skjnldsv mentioned this pull request Jan 10, 2025
8 tasks
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Jan 10, 2025
@skjnldsv skjnldsv self-assigned this Jan 10, 2025
@skjnldsv skjnldsv changed the title feat(api): File conversion API feat(api): File conversion Files action Jan 10, 2025
@skjnldsv skjnldsv force-pushed the feat/file-conversion-provider-front branch from 48fb7eb to 6d94040 Compare January 10, 2025 11:11
@skjnldsv skjnldsv changed the base branch from feat/file-conversion-provider to master January 10, 2025 11:11
@skjnldsv

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the feat/file-conversion-provider-front branch 3 times, most recently from 39d45ce to a9f9549 Compare January 22, 2025 08:19
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 22, 2025
@skjnldsv
Copy link
Member Author

Should be good to go!

@skjnldsv skjnldsv force-pushed the feat/file-conversion-provider-front branch from a9f9549 to d6b8ccb Compare January 22, 2025 08:33
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor comments :)

apps/files/src/actions/convertAction.ts Outdated Show resolved Hide resolved
apps/files/src/actions/convertUtils.ts Outdated Show resolved Hide resolved
apps/files/src/actions/convertUtils.ts Show resolved Hide resolved
apps/files/src/store/files.ts Outdated Show resolved Hide resolved
core/Controller/PreviewController.php Show resolved Hide resolved
apps/admin_audit/composer/composer/InstalledVersions.php Outdated Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the feat/file-conversion-provider-front branch 2 times, most recently from 994f43c to 14d97d7 Compare January 22, 2025 08:52
@skjnldsv skjnldsv marked this pull request as ready for review January 22, 2025 08:52
@skjnldsv skjnldsv requested a review from artonge January 22, 2025 08:56
apps/files/src/actions/convertAction.ts Outdated Show resolved Hide resolved
apps/files/src/actions/convertUtils.ts Outdated Show resolved Hide resolved
apps/files/src/actions/convertUtils.ts Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the feat/file-conversion-provider-front branch from ea1f90c to a028fe6 Compare January 22, 2025 09:44
@skjnldsv skjnldsv requested a review from artonge January 22, 2025 09:44
@skjnldsv
Copy link
Member Author

/compile rebase

@nextcloud-command nextcloud-command force-pushed the feat/file-conversion-provider-front branch from 54bf0fb to eb92120 Compare January 22, 2025 16:31
@skjnldsv skjnldsv merged commit 49cfd30 into master Jan 22, 2025
189 checks passed
@skjnldsv skjnldsv deleted the feat/file-conversion-provider-front branch January 22, 2025 18:28
@Altahrim Altahrim mentioned this pull request Jan 23, 2025
@juliusknorr juliusknorr mentioned this pull request Jan 23, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File conversion front-end
5 participants