-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deepsomatic tool #1647
base: dev
Are you sure you want to change the base?
Add deepsomatic tool #1647
Conversation
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.0.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
I like where this is going. |
Fix Changelog
intervals_only = intervals.map { intervals, num_intervals -> [[], intervals]} | ||
|
||
DEEPSOMATIC(cram_normal_tumor_intervals, intervals_only, fasta, fasta_fai, [ [ id:'null' ], [] ]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work with multiple samples? We need to ensure that each sample is run with each interval subfile and then properly merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intervals subfiles are passed to DEEPSOMATIC process through ext.prefix parameter (this is described in conf/modules/deepsomatic.config) and then output is merged with MERGE_DEEPSOMATIC_VCF and MERGE_DEEPSOMATIC_GVCF (lines 52-53)
minor issues with managing merge conflicts, I made suggestions |
Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
This is a first version of PR to add deepsomatic capabilities into sarek pipeline. Currently this PR contains code changes only (without tests and most of metadata) and created to gather the initial feedback.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).