Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nf-core pipelines download -r to download commits #3374

Merged
merged 11 commits into from
Jan 13, 2025
Merged

Conversation

muffato
Copy link
Member

@muffato muffato commented Dec 20, 2024

Supersedes #2906

This is to allow downloading a specific commit of a pipeline, instead of only a branch / tag.
As @ewels suggested in the original pull-request, I only check the commit once we know it's neither a branch nor a tag. It's a single extra query, and it won't download the whole list of possible commits.

I could reuse the tests @fellen31 wrote. Credits to them

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.04%. Comparing base (d4d3f36) to head (570ae2b).
Report is 12 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muffato muffato marked this pull request as ready for review December 20, 2024 23:59
@muffato muffato added enhancement download nf-core download labels Dec 21, 2024
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I only made a couple of clean-up code suggestions.
Also tagging @MatthiasZepper in case you want to have a quick look

tests/pipelines/test_download.py Outdated Show resolved Hide resolved
tests/pipelines/test_download.py Outdated Show resolved Hide resolved
tests/pipelines/test_download.py Outdated Show resolved Hide resolved
tests/pipelines/test_download.py Outdated Show resolved Hide resolved
tests/pipelines/test_download.py Show resolved Hide resolved
tests/pipelines/test_download.py Outdated Show resolved Hide resolved
@MatthiasZepper
Copy link
Member

Thanks for tagging. I took a brief look and have no objections.

@muffato
Copy link
Member Author

muffato commented Jan 13, 2025

I've addressed all the comments, merged dev in, and fixed the conflict in CHANGELOG.md

@muffato
Copy link
Member Author

muffato commented Jan 13, 2025

All CI pass and the PR had already been approved. Merging now

@muffato muffato merged commit f58510f into dev Jan 13, 2025
89 checks passed
@muffato muffato deleted the download_commits branch January 13, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
download nf-core download enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants