-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow nf-core pipelines download -r
to download commits
#3374
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
28d0305
to
ec254d0
Compare
ec254d0
to
b0b9559
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I only made a couple of clean-up code suggestions.
Also tagging @MatthiasZepper in case you want to have a quick look
Thanks for tagging. I took a brief look and have no objections. |
Co-authored-by: Júlia Mir Pedrol <[email protected]>
Co-authored-by: Júlia Mir Pedrol <[email protected]>
I've addressed all the comments, merged |
All CI pass and the PR had already been approved. Merging now |
Supersedes #2906
This is to allow downloading a specific commit of a pipeline, instead of only a branch / tag.
As @ewels suggested in the original pull-request, I only check the commit once we know it's neither a branch nor a tag. It's a single extra query, and it won't download the whole list of possible commits.
I could reuse the tests @fellen31 wrote. Credits to them
PR checklist
CHANGELOG.md
is updateddocs
is updated