Skip to content

Commit

Permalink
Rename arguments for clarity and ensure correct usage
Browse files Browse the repository at this point in the history
  • Loading branch information
ciroque committed Nov 27, 2023
1 parent f77cc0b commit 3d9f7e8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion internal/certification/certificates.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ func (c *Certificates) handleDeleteEvent(obj interface{}) {
logrus.Debugf("Certificates::handleDeleteEvent: certificates (%d)", len(c.Certificates))
}

func (c *Certificates) handleUpdateEvent(oldValue interface{}, newValue interface{}) {
func (c *Certificates) handleUpdateEvent(_ interface{}, newValue interface{}) {
logrus.Debug("Certificates::handleUpdateEvent")

secret, ok := newValue.(*corev1.Secret)
Expand Down
4 changes: 2 additions & 2 deletions internal/configuration/settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,10 @@ func (s *Settings) handleDeleteEvent(obj interface{}) {
}
}

func (s *Settings) handleUpdateEvent(_ interface{}, obj interface{}) {
func (s *Settings) handleUpdateEvent(_ interface{}, newValue interface{}) {
logrus.Debug("Settings::handleUpdateEvent")

configMap, yes := isOurConfig(obj)
configMap, yes := isOurConfig(newValue)
if !yes {
return
}
Expand Down

0 comments on commit 3d9f7e8

Please sign in to comment.