Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signals): patch state methods do not correctly resolve generic co… #4646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ivashikhmin
Copy link

@ivashikhmin ivashikhmin commented Dec 29, 2024

…llection names withEntities

Ensures type-safety of named entity collections with patchState helpers

fixes #4638

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4638

What is the new behavior?

Collection extends string generic could be used to make features with named entity collections (withEntities) and state updaters, e.g. addEntity, in type-safe manner and allow method naming like in
ngrx-toolkit withDataService

Does this PR introduce a breaking change?

[ ] Yes
[x] No

…llection names withEntities

Ensures type-safety of named entity collections with patchState helpers

fixes ngrx#4638
Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 4f7181f
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6771c83f96dc7b0008fcc8cf

@ivashikhmin ivashikhmin marked this pull request as ready for review December 29, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch methods do not correctly resolve generic collection names withEntities
1 participant