Fix appveyor vcpkg cache directory #447

scribam · 2024-07-26T18:16:09Z

vcpkg in manifest mode creates the vcpkg_installed directory in the build directory

Amend commit d0ab655

CMake configure step exposed the vcpkg_installed directory in appveyor logs:
-- Found ZLIB: optimized;C:/projects/libzip/build/vcpkg_installed/x64-windows/lib/zlib.lib;debug;C:/projects/libzip/build/vcpkg_installed/x64-windows/debug/lib/zlibd.lib (found suitable version "1.3.1", minimum required is "1.1.2")

0-wiz-0 · 2024-07-26T21:06:47Z

Was the test successful?

scribam · 2024-07-26T21:09:31Z

By default, saving cache is disabled in Pull Request builds so I am now trying with the main branch in my fork, still wip.

vcpkg in manifest mode creates the vcpkg_installed directory in the build directory

scribam · 2024-07-27T08:58:53Z

Without cache https://ci.appveyor.com/project/scribam/libzip/builds/50295040/job/allxlkipr79aaqr6
Total install time: 1.7 min

Restored 0 package(s) from C:\vcpkg.cache in 260 us. Use --debug to see more details.
Installing 1/6 vcpkg-cmake:x64-windows@2024-04-23...
Building vcpkg-cmake:x64-windows@2024-04-23...
-- Installing: C:/Tools/vcpkg/packages/vcpkg-cmake_x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake
-- Installing: C:/Tools/vcpkg/packages/vcpkg-cmake_x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake
-- Installing: C:/Tools/vcpkg/packages/vcpkg-cmake_x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake
-- Installing: C:/Tools/vcpkg/packages/vcpkg-cmake_x64-windows/share/vcpkg-cmake/vcpkg-port-config.cmake
-- Installing: C:/Tools/vcpkg/packages/vcpkg-cmake_x64-windows/share/vcpkg-cmake/copyright
-- Performing post-build validation
Stored binaries in 1 destinations in 39.9 ms.
Elapsed time to handle vcpkg-cmake:x64-windows: 135 ms
vcpkg-cmake:x64-windows package ABI: 753197d61f1c33703b558c2d893b418f115de6f08e025f692f8b0d063a6ccbce
Installing 2/6 bzip2[core,tool]:[email protected]#5...
Building bzip2[core,tool]:[email protected]#5...
-- Downloading https://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz -> bzip2-1.0.8.tar.gz...
-- Extracting source C:/Tools/vcpkg/downloads/bzip2-1.0.8.tar.gz
-- Applying patch fix-import-export-macros.patch
-- Using source at C:/Tools/vcpkg/buildtrees/bzip2/src/bzip2-1-336d4794a3.clean
-- Found external ninja('1.10.2').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Fixing pkgconfig file: C:/Tools/vcpkg/packages/bzip2_x64-windows/lib/pkgconfig/bzip2.pc
-- Downloading https://mirror.msys2.org/mingw/mingw64/mingw-w64-x86_64-pkgconf-1~2.2.0-1-any.pkg.tar.zst;https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-pkgconf-1~2.2.0-1-any.pkg.tar.zst;https://mirror.yandex.ru/mirrors/msys2/mingw/mingw64/mingw-w64-x86_64-pkgconf-1~2.2.0-1-any.pkg.tar.zst;https://mirrors.tuna.tsinghua.edu.cn/msys2/mingw/mingw64/mingw-w64-x86_64-pkgconf-1~2.2.0-1-any.pkg.tar.zst;https://mirrors.ustc.edu.cn/msys2/mingw/mingw64/mingw-w64-x86_64-pkgconf-1~2.2.0-1-any.pkg.tar.zst;https://mirror.selfnet.de/msys2/mingw/mingw64/mingw-w64-x86_64-pkgconf-1~2.2.0-1-any.pkg.tar.zst -> msys2-mingw-w64-x86_64-pkgconf-1~2.2.0-1-any.pkg.tar.zst...
-- Downloading https://mirror.msys2.org/msys/x86_64/msys2-runtime-3.5.3-3-x86_64.pkg.tar.zst;https://repo.msys2.org/msys/x86_64/msys2-runtime-3.5.3-3-x86_64.pkg.tar.zst;https://mirror.yandex.ru/mirrors/msys2/msys/x86_64/msys2-runtime-3.5.3-3-x86_64.pkg.tar.zst;https://mirrors.tuna.tsinghua.edu.cn/msys2/msys/x86_64/msys2-runtime-3.5.3-3-x86_64.pkg.tar.zst;https://mirrors.ustc.edu.cn/msys2/msys/x86_64/msys2-runtime-3.5.3-3-x86_64.pkg.tar.zst;https://mirror.selfnet.de/msys2/msys/x86_64/msys2-runtime-3.5.3-3-x86_64.pkg.tar.zst -> msys2-msys2-runtime-3.5.3-3-x86_64.pkg.tar.zst...
-- Using msys root at C:/Tools/vcpkg/downloads/tools/msys2/1e74ca60daa10104
-- Fixing pkgconfig file: C:/Tools/vcpkg/packages/bzip2_x64-windows/debug/lib/pkgconfig/bzip2.pc
-- Installing: C:/Tools/vcpkg/packages/bzip2_x64-windows/share/bzip2/copyright
-- Performing post-build validation
Stored binaries in 1 destinations in 155 ms.
Elapsed time to handle bzip2:x64-windows: 15 s
bzip2:x64-windows package ABI: 327ba8e1d78e6b21e27d02ad51cd8c94b8a615824c3b2a464edd1cff4fce4a12
Installing 3/6 vcpkg-cmake-config:x64-windows@2024-05-23...
Building vcpkg-cmake-config:x64-windows@2024-05-23...
-- Installing: C:/Tools/vcpkg/packages/vcpkg-cmake-config_x64-windows/share/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake
-- Installing: C:/Tools/vcpkg/packages/vcpkg-cmake-config_x64-windows/share/vcpkg-cmake-config/vcpkg-port-config.cmake
-- Installing: C:/Tools/vcpkg/packages/vcpkg-cmake-config_x64-windows/share/vcpkg-cmake-config/copyright
-- Skipping post-build validation due to VCPKG_POLICY_EMPTY_PACKAGE
Stored binaries in 1 destinations in 21.6 ms.
Elapsed time to handle vcpkg-cmake-config:x64-windows: 81.1 ms
vcpkg-cmake-config:x64-windows package ABI: b33ff0923611214b0f8765c68f944c5b5a1bccae6b0a88268bf77ab9273b2433
Installing 4/6 liblzma:[email protected]...
Building liblzma:[email protected]...
-- Downloading https://github.com/tukaani-project/xz/archive/v5.4.4.tar.gz -> tukaani-project-xz-v5.4.4.tar.gz...
-- Extracting source C:/Tools/vcpkg/downloads/tukaani-project-xz-v5.4.4.tar.gz
-- Applying patch fix_config_include.patch
-- Applying patch win_output_name.patch
-- Applying patch add_support_ios.patch
-- Applying patch build-tools.patch
-- Using source at C:/Tools/vcpkg/buildtrees/liblzma/src/v5.4.4-6f848a7cca.clean
-- Found external ninja('1.10.2').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Fixing pkgconfig file: C:/Tools/vcpkg/packages/liblzma_x64-windows/lib/pkgconfig/liblzma.pc
-- Using cached msys2-mingw-w64-x86_64-pkgconf-1~2.2.0-1-any.pkg.tar.zst.
-- Using cached msys2-msys2-runtime-3.5.3-3-x86_64.pkg.tar.zst.
-- Using msys root at C:/Tools/vcpkg/downloads/tools/msys2/1e74ca60daa10104
-- Fixing pkgconfig file: C:/Tools/vcpkg/packages/liblzma_x64-windows/debug/lib/pkgconfig/liblzma.pc
-- Installing: C:/Tools/vcpkg/packages/liblzma_x64-windows/share/liblzma/copyright
-- Performing post-build validation
Stored binaries in 1 destinations in 478 ms.
Elapsed time to handle liblzma:x64-windows: 42 s
liblzma:x64-windows package ABI: 72546c33b40ca63ecac5b8fe1eb081c3345c89aebce3dc3ab11e83b46157aeef
Installing 5/6 zlib:[email protected]...
Building zlib:[email protected]...
-- Downloading https://github.com/madler/zlib/archive/v1.3.1.tar.gz -> madler-zlib-v1.3.1.tar.gz...
-- Extracting source C:/Tools/vcpkg/downloads/madler-zlib-v1.3.1.tar.gz
-- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch
-- Applying patch 0002-build-static-or-shared-not-both.patch
-- Applying patch 0003-android-and-mingw-fixes.patch
-- Using source at C:/Tools/vcpkg/buildtrees/zlib/src/v1.3.1-2e5db616bf.clean
-- Found external ninja('1.10.2').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: C:/Tools/vcpkg/packages/zlib_x64-windows/share/zlib/vcpkg-cmake-wrapper.cmake
-- Fixing pkgconfig file: C:/Tools/vcpkg/packages/zlib_x64-windows/lib/pkgconfig/zlib.pc
-- Using cached msys2-mingw-w64-x86_64-pkgconf-1~2.2.0-1-any.pkg.tar.zst.
-- Using cached msys2-msys2-runtime-3.5.3-3-x86_64.pkg.tar.zst.
-- Using msys root at C:/Tools/vcpkg/downloads/tools/msys2/1e74ca60daa10104
-- Fixing pkgconfig file: C:/Tools/vcpkg/packages/zlib_x64-windows/debug/lib/pkgconfig/zlib.pc
-- Installing: C:/Tools/vcpkg/packages/zlib_x64-windows/share/zlib/copyright
-- Performing post-build validation
Stored binaries in 1 destinations in 183 ms.
Elapsed time to handle zlib:x64-windows: 12 s
zlib:x64-windows package ABI: 0fb75f41209ecd3ac84b348e705a6d8d1b568292828ac2558f60de533da460b0
Installing 6/6 zstd:[email protected]...
Building zstd:[email protected]...
-- Downloading https://github.com/facebook/zstd/archive/v1.5.6.tar.gz -> facebook-zstd-v1.5.6.tar.gz...
-- Extracting source C:/Tools/vcpkg/downloads/facebook-zstd-v1.5.6.tar.gz
-- Applying patch no-static-suffix.patch
-- Applying patch fix-emscripten-and-clang-cl.patch
-- Applying patch fix-windows-rc-compile.patch
-- Using source at C:/Tools/vcpkg/buildtrees/zstd/src/v1.5.6-6d2acef635.clean
-- Found external ninja('1.10.2').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Fixing pkgconfig file: C:/Tools/vcpkg/packages/zstd_x64-windows/lib/pkgconfig/libzstd.pc
-- Using cached msys2-mingw-w64-x86_64-pkgconf-1~2.2.0-1-any.pkg.tar.zst.
-- Using cached msys2-msys2-runtime-3.5.3-3-x86_64.pkg.tar.zst.
-- Using msys root at C:/Tools/vcpkg/downloads/tools/msys2/1e74ca60daa10104
-- Fixing pkgconfig file: C:/Tools/vcpkg/packages/zstd_x64-windows/debug/lib/pkgconfig/libzstd.pc
-- Installing: C:/Tools/vcpkg/packages/zstd_x64-windows/share/zstd/usage
-- Performing post-build validation
Stored binaries in 1 destinations in 821 ms.
Elapsed time to handle zstd:x64-windows: 34 s
zstd:x64-windows package ABI: 8d5a45e535edb4b7c6114cd6435e573a2008744751cf2db99617c9729e3552fa
Total install time: 1.7 min

With cache https://ci.appveyor.com/project/scribam/libzip/builds/50295188/job/qpdoo4m7jqs6yglg
Total install time: 49.1 ms

Restored 6 package(s) from C:\vcpkg.cache in 221 ms. Use --debug to see more details.
Installing 1/6 vcpkg-cmake:x64-windows@2024-04-23...
Elapsed time to handle vcpkg-cmake:x64-windows: 4.99 ms
vcpkg-cmake:x64-windows package ABI: 753197d61f1c33703b558c2d893b418f115de6f08e025f692f8b0d063a6ccbce
Installing 2/6 bzip2[core,tool]:[email protected]#5...
Elapsed time to handle bzip2:x64-windows: 8.89 ms
bzip2:x64-windows package ABI: 327ba8e1d78e6b21e27d02ad51cd8c94b8a615824c3b2a464edd1cff4fce4a12
Installing 3/6 vcpkg-cmake-config:x64-windows@2024-05-23...
Elapsed time to handle vcpkg-cmake-config:x64-windows: 3.95 ms
vcpkg-cmake-config:x64-windows package ABI: b33ff0923611214b0f8765c68f944c5b5a1bccae6b0a88268bf77ab9273b2433
Installing 4/6 liblzma:[email protected]...
Elapsed time to handle liblzma:x64-windows: 11.5 ms
liblzma:x64-windows package ABI: 72546c33b40ca63ecac5b8fe1eb081c3345c89aebce3dc3ab11e83b46157aeef
Installing 5/6 zlib:[email protected]...
Elapsed time to handle zlib:x64-windows: 8.03 ms
zlib:x64-windows package ABI: 0fb75f41209ecd3ac84b348e705a6d8d1b568292828ac2558f60de533da460b0
Installing 6/6 zstd:[email protected]...
Elapsed time to handle zstd:x64-windows: 10.6 ms
zstd:x64-windows package ABI: 8d5a45e535edb4b7c6114cd6435e573a2008744751cf2db99617c9729e3552fa
Total install time: 49.1 ms

scribam · 2024-07-27T09:00:09Z

appveyor.yml

@@ -65,8 +66,6 @@ before_build:
  cmd: >-
    py -m pip install nihtest

-    vcpkg install


This is not required in manifest mode, CMake will take care of this install automatically

0-wiz-0 · 2024-07-27T09:19:56Z

Looks good, thanks for diving into this!

scribam marked this pull request as draft July 26, 2024 21:09

Fix appveyor vcpkg cache directory

dc6a590

vcpkg in manifest mode creates the vcpkg_installed directory in the build directory

scribam marked this pull request as ready for review July 27, 2024 08:58

scribam commented Jul 27, 2024

View reviewed changes

0-wiz-0 merged commit 0b605c2 into nih-at:main Jul 27, 2024
1 of 2 checks passed

scribam deleted the appveyor-vcpkg-cache branch July 27, 2024 09:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix appveyor vcpkg cache directory #447

Fix appveyor vcpkg cache directory #447

scribam commented Jul 26, 2024

0-wiz-0 commented Jul 26, 2024

scribam commented Jul 26, 2024

scribam commented Jul 27, 2024

scribam Jul 27, 2024

0-wiz-0 commented Jul 27, 2024

Fix appveyor vcpkg cache directory #447

Fix appveyor vcpkg cache directory #447

Conversation

scribam commented Jul 26, 2024

0-wiz-0 commented Jul 26, 2024

scribam commented Jul 26, 2024

scribam commented Jul 27, 2024

scribam Jul 27, 2024

Choose a reason for hiding this comment

0-wiz-0 commented Jul 27, 2024