Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error msg for managed memory in passCopyToSink #24605

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Error msg for managed memory in passCopyToSink #24605

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0109817
report error to user
elcritch Jan 7, 2025
5b63c81
report error to user
elcritch Jan 7, 2025
f6df680
fix copy and paste, forget if
elcritch Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compiler/injectdestructors.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,9 @@ proc passCopyToSink(n: PNode; c: var Con; s: var Scope): PNode =
("cannot move '$1', passing '$1' to a sink parameter introduces an implicit copy") % $n)
else:
if c.graph.config.selectedGC in {gcArc, gcOrc, gcAtomicArc}:
assert(not containsManagedMemory(nTyp))
if containsManagedMemory(nTyp):
localError(c.graph.config, n.info, errInternal,
"type contains managed memory: '$1' for '$2' " % [$nTyp, $n] )
if nTyp.skipTypes(abstractInst).kind in {tyOpenArray, tyVarargs}:
localError(c.graph.config, n.info, "cannot create an implicit openArray copy to be passed to a sink parameter")
result.add newTree(nkAsgn, tmp, p(n, c, s, normal))
Expand Down