Feat non block and nim2 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… introduce waitForReceive to wait a message based on RCVTIMEO in a blocking way instead; add TODO comment about exception in =destroy introduced by Nim 2.0
|
CI fails because doc gen and compiler do not agree. Opened nim-lang/Nim#23065 in reference |
|
@Araq I think this is in a state that can be merged - unless you wish to review / request changes first. I'm not super happy about the waitAll function in async that discard every possible exception, but that was required to satisfy the I'm still not sure how Once this is merged, i'll tag a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tryReceive being actually blocking based on a timeout and make it non blocking instead.
Introduce waitForReceive to handle timeout based reception.
TODO : modify =destroy hook to remove var T prototype