Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/test.mk: Rebuild out-of-date test modules only #881

Conversation

dumbbell
Copy link
Contributor

@dumbbell dumbbell commented Apr 3, 2020

... instead of always rebuilding all of them each time a testsuite is executed.

The only exception is when a Makefile was modified: like for main source files, test modules are all recompiled in this case.

@dumbbell
Copy link
Contributor Author

dumbbell commented Apr 3, 2020

In the context of rabbitmq-server, time make test-build (when there is nothing to do) goes from 7 seconds to 1.2 seconds.

@essen
Copy link
Member

essen commented Apr 3, 2020

I've been wondering about that as well, thanks for doing it!

core/test.mk Outdated Show resolved Hide resolved
@dumbbell dumbbell force-pushed the rebuild-out-of-date-test-modules-only branch 2 times, most recently from 78b73c0 to b91a30b Compare April 13, 2020 11:32
core/test.mk Outdated Show resolved Hide resolved
@essen
Copy link
Member

essen commented Apr 13, 2020

Please also add a small test to confirm it works as intended.

@dumbbell dumbbell force-pushed the rebuild-out-of-date-test-modules-only branch from b91a30b to b882390 Compare April 15, 2020 09:16
@dumbbell
Copy link
Contributor Author

I added a testcase and pushed.

@dumbbell dumbbell force-pushed the rebuild-out-of-date-test-modules-only branch from b882390 to c0d4686 Compare April 16, 2020 09:22
@dumbbell
Copy link
Contributor Author

There are several failures on CentOS in CI that I can't reproduce locally. What do you do usually to debug such errors?

@essen
Copy link
Member

essen commented Apr 16, 2020

Forgot to disable -j on the PR pipeline, CentOS is using an old Make or something and -j causes failures. Next push should succeed.

@essen
Copy link
Member

essen commented Apr 16, 2020

Windows is being annoying again, I'll fix it later today.

@dumbbell dumbbell force-pushed the rebuild-out-of-date-test-modules-only branch from c0d4686 to e5d1ed0 Compare April 16, 2020 12:40
@dumbbell
Copy link
Contributor Author

Ok, I just force-pushed to trigger a new build.

@essen
Copy link
Member

essen commented Apr 16, 2020

Alpine is a flaky test that I'm tentatively improving in the most recent commit. Anyway don't bother rebuilding.

core/test.mk Outdated Show resolved Hide resolved
@dumbbell dumbbell force-pushed the rebuild-out-of-date-test-modules-only branch from e5d1ed0 to 9a53fea Compare April 20, 2020 10:08
test/core_app.mk Outdated Show resolved Hide resolved
@essen
Copy link
Member

essen commented Apr 20, 2020

Just one minor comment about the test and we're good!

... instead of always rebuilding all of them each time a testsuite is
executed.

The only exception is when a Makefile was modified: like for main
source files, test modules are all recompiled in this case.
@essen
Copy link
Member

essen commented Apr 21, 2020

Merging, thanks!

@essen essen closed this Apr 21, 2020
@dumbbell dumbbell deleted the rebuild-out-of-date-test-modules-only branch April 21, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants