-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/test.mk: Rebuild out-of-date test modules only #881
core/test.mk: Rebuild out-of-date test modules only #881
Conversation
In the context of rabbitmq-server, |
I've been wondering about that as well, thanks for doing it! |
78b73c0
to
b91a30b
Compare
Please also add a small test to confirm it works as intended. |
b91a30b
to
b882390
Compare
I added a testcase and pushed. |
b882390
to
c0d4686
Compare
There are several failures on CentOS in CI that I can't reproduce locally. What do you do usually to debug such errors? |
Forgot to disable |
Windows is being annoying again, I'll fix it later today. |
c0d4686
to
e5d1ed0
Compare
Ok, I just force-pushed to trigger a new build. |
Alpine is a flaky test that I'm tentatively improving in the most recent commit. Anyway don't bother rebuilding. |
e5d1ed0
to
9a53fea
Compare
Just one minor comment about the test and we're good! |
... instead of always rebuilding all of them each time a testsuite is executed. The only exception is when a Makefile was modified: like for main source files, test modules are all recompiled in this case.
9a53fea
to
eed54f2
Compare
Merging, thanks! |
... instead of always rebuilding all of them each time a testsuite is executed.
The only exception is when a Makefile was modified: like for main source files, test modules are all recompiled in this case.