ENH: Simplify table2string implementation #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous table2string implementation reimplemented Python formatting, calculating spaces for aligning left, right or center. This patch just translates our mini-language into the Python mini-language, and updates the tests. Previously, when centering required adding an odd number of spaces, we added the extra to the left, while Python adds to the right. This difference does not seem worth preserving. This also avoids allocating a numpy array in order to transpose by using the `zip(*list)` trick.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1403 +/- ##
==========================================
+ Coverage 95.37% 95.38% +0.01%
==========================================
Files 207 207
Lines 29672 29659 -13
Branches 3018 3014 -4
==========================================
- Hits 28300 28291 -9
+ Misses 934 932 -2
+ Partials 438 436 -2 ☔ View full report in Codecov by Sentry. |
effigies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous table2string implementation reimplemented Python formatting, calculating spaces for aligning left, right or center. This patch just translates our mini-language into the Python mini-language, and updates the tests.
Previously, when centering required adding an odd number of spaces, we added the extra to the left, while Python adds to the right. This difference does not seem worth preserving.
This also avoids allocating a numpy array in order to transpose by using the
zip(*list)trick. Finally, we concatenate the strings in single shots, which separates the entry formatting from the table formatting and makes the function easier to understand, IMO.