feat!: update go-sdk to v1 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjholm
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Really appreciate all the work that went into this @denilbhatt0814, thank you so much for contributing 🙌 .
Just a few small things for now, still reviewing but so far everything looks great 👍
|
@tjholm I have made the requested changes, please go through them |
tjholm
reviewed
Jun 5, 2024
…d of an int | removed test case for PreSignUrl expiry validation
tjholm
approved these changes
Jun 17, 2024
HomelessDinosaur
approved these changes
Jun 18, 2024
davemooreuws
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
This PR has modified several files to make it in sync with Nitric V1. The primarily affected files are in
./api/along with appropriate tests for each package. I have also modified the security options applied to API resources to support OIDC.In addition, the PR also brings new packageworkers, separating the asynchronous actions which can be taken on resources; eg:BlobEvents,Subscriptionto topics, and so on. Lastly, there have also been slight modifications inpackage nitricto accommodate the usage of the aforementioned workers.