Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghostty: don't install package on darwin platforms #6298

Closed

Conversation

HeitorAugustoLN
Copy link
Member

Description

Closes #6295

Makes ghostty package option nullable on darwin platform

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@teto
Copy link
Collaborator

teto commented Jan 10, 2025

rather than making it nullable, it could be added to home.packages only for supported platforms ?

@HeitorAugustoLN HeitorAugustoLN changed the title ghostty: make package nullable on darwin platform ghostty: don't install package on darwin platforms Jan 10, 2025
@HeitorAugustoLN
Copy link
Member Author

Closing in favor of: #6300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ghostty package should be nullable for unsupported platforms
2 participants