Always set nix-direnv-reload as executable #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicknovitski
force-pushed
the
patch-1
branch
2 times, most recently
from
06a0965 to
c956391
Compare
Mic92
reviewed
Nov 26, 2024
Mic92
reviewed
Nov 26, 2024
|
Calling |
I am not sure why, but on docker bind mounts using virtiofs and gcsFuse, `-x` is always true for a file which exists. This means that, before this commit was merged, when using nix-direnv in manual mode on a devcontainer with docker desktop on mac, `nix-direnv-reload` would be created and then not set as executable, and if they tried to run it users would see an error like `bad interpreter: Permission denied`. After this commit is merged, these scenarios work.
nicknovitski
force-pushed
the
patch-1
branch
from
c956391 to
8a94275
Compare
nicknovitski
changed the title
stat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why, but on docker bind mounts using virtiofs and gcsFuse,
-xis always true for a file which exists. This means that, before this commit was merged, when using nix-direnv in manual mode on a devcontainer with docker desktop on mac,nix-direnv-reloadwould be created and then not set as executable, and if they tried to run it users would see an error likebad interpreter: Permission denied. After this commit is merged, these scenarios work.Here's some discussion: docker/for-mac#5029
Other tools have run into this: pre-commit/identify#189