tests: replace helpers.enableExceptInTests
with module option
#2047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on matrix, the current
helpers.enableExceptInTests
is problematic for a couple reasons:mkTestDerivationFromNixvimModule
, notmkTestDerivationFromNvim
helpers
whether or not it'll be used for testsThis resolves those, however it has its own issues:
mkTestDerivationFromNvim
effectively evaluates the modules twice (once before being called, then again internally)mkTestDerivationFromNixvimModule
config.test.derivation
directly anywayenableExceptInTests
is removed immediately, with no grace period for the deprecationI wonder if it'd be better to not provide any direct support for distinguishing between test/non-test contexts?
Or perhaps we should double down on the
evalNixvimTest
function proposed in #1989's description and use that to set the context?See #1095