Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/clangd-extensions: convert to mkNeovimPlugin #2808

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

jolars
Copy link
Contributor

@jolars jolars commented Jan 8, 2025

Convert clangd-extensions to mkNeovimPlugin. I also got rid of some deprecated things.

@jolars jolars force-pushed the convert-clangd-extensions branch from 43af31d to bee60ae Compare January 8, 2025 22:03
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already. Here is a first batch of feedback.

plugins/by-name/clangd-extensions/default.nix Outdated Show resolved Hide resolved
plugins/by-name/clangd-extensions/default.nix Outdated Show resolved Hide resolved
plugins/by-name/clangd-extensions/default.nix Outdated Show resolved Hide resolved
plugins/by-name/clangd-extensions/default.nix Outdated Show resolved Hide resolved
plugins/by-name/clangd-extensions/default.nix Outdated Show resolved Hide resolved
plugins/by-name/clangd-extensions/default.nix Outdated Show resolved Hide resolved
plugins/by-name/clangd-extensions/default.nix Outdated Show resolved Hide resolved
plugins/by-name/clangd-extensions/default.nix Outdated Show resolved Hide resolved
@jolars jolars force-pushed the convert-clangd-extensions branch 3 times, most recently from 544dbb9 to 5dfaf48 Compare January 9, 2025 07:49
@jolars jolars force-pushed the convert-clangd-extensions branch from 544fd5c to 8f790e5 Compare January 9, 2025 08:20
@jolars jolars force-pushed the convert-clangd-extensions branch from 0a0fff9 to db9c1a4 Compare January 9, 2025 19:17
@jolars jolars force-pushed the convert-clangd-extensions branch from 8e70a96 to db667ca Compare January 10, 2025 08:04
@jolars jolars force-pushed the convert-clangd-extensions branch from 97a95b0 to f4f4acc Compare January 10, 2025 08:48
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice work :)

@khaneliman
Copy link
Contributor

@mergify queue

Copy link
Contributor

mergify bot commented Jan 12, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 35d6c12

Wrap code in backticks

Co-authored-by: Gaétan Lepage <[email protected]>

Surround right_aling with backticks

Co-authored-by: Gaétan Lepage <[email protected]>

Set default of `inline` to true since we are on nvim >= 0.10

Document `highlights`

Use `mkUnsignedInt`

Co-authored-by: Gaétan Lepage <[email protected]>

Improve warning

Co-authored-by: Gaétan Lepage <[email protected]>

Readd deprecated options

Document icons

Rename removed-options.nix to deprecations.nix

Reformat raw string

Co-authored-by: Gaétan Lepage <[email protected]>

Don't specify rawLua

Co-authored-by: Gaétan Lepage <[email protected]>

Use mkDefault and make utf-16 workaround leaner

Don't wrap warning

Co-authored-by: Matt Sturgeon <[email protected]>

Change by -> after

Co-authored-by: Matt Sturgeon <[email protected]>

Document border options
@nix-infra-bot nix-infra-bot force-pushed the convert-clangd-extensions branch from f4f4acc to 35d6c12 Compare January 12, 2025 20:58
Copy link
Contributor

mergify bot commented Jan 12, 2025

This pull request, with head sha 35d6c12626f9895cd5d8ccf5d19c3d00de394334, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha 35d6c12626f9895cd5d8ccf5d19c3d00de394334 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch convert-clangd-extensions, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit 35d6c12 into nix-community:main Jan 12, 2025
4 checks passed
@mergify mergify bot temporarily deployed to github-pages January 12, 2025 21:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants