-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/clangd-extensions: convert to mkNeovimPlugin #2808
Conversation
43af31d
to
bee60ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good already. Here is a first batch of feedback.
544dbb9
to
5dfaf48
Compare
544fd5c
to
8f790e5
Compare
0a0fff9
to
db9c1a4
Compare
8e70a96
to
db667ca
Compare
97a95b0
to
f4f4acc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very nice work :)
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 35d6c12 |
Wrap code in backticks Co-authored-by: Gaétan Lepage <[email protected]> Surround right_aling with backticks Co-authored-by: Gaétan Lepage <[email protected]> Set default of `inline` to true since we are on nvim >= 0.10 Document `highlights` Use `mkUnsignedInt` Co-authored-by: Gaétan Lepage <[email protected]> Improve warning Co-authored-by: Gaétan Lepage <[email protected]> Readd deprecated options Document icons Rename removed-options.nix to deprecations.nix Reformat raw string Co-authored-by: Gaétan Lepage <[email protected]> Don't specify rawLua Co-authored-by: Gaétan Lepage <[email protected]> Use mkDefault and make utf-16 workaround leaner Don't wrap warning Co-authored-by: Matt Sturgeon <[email protected]> Change by -> after Co-authored-by: Matt Sturgeon <[email protected]> Document border options
f4f4acc
to
35d6c12
Compare
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Convert clangd-extensions to mkNeovimPlugin. I also got rid of some deprecated things.