Fix inline local includes edge cases #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #include must be the start of a line - the inlined included is placed in the same line as the original #include
loostrum
commented
Jul 18, 2024
csbnw
approved these changes
Jul 18, 2024
Co-authored-by: Bram Veenboer <[email protected]>
Co-authored-by: Bram Veenboer <[email protected]>
for more information, see https://pre-commit.ci
csbnw
reviewed
Jul 18, 2024
|
Could you update the |
Co-authored-by: Bram Veenboer <[email protected]>
loostrum
force-pushed
the
fix-inline-local-includes
branch
from
9b1bf44 to
172f42a
Compare
for more information, see https://pre-commit.ci
matmanc
pushed a commit
that referenced
this pull request
Jan 20, 2025
* Changes to incline local includes: - #include must be the start of a line - the inlined included is placed in the same line as the original #include * Update cmake/cudawrappers-helper.cmake Co-authored-by: Bram Veenboer <[email protected]> * Update cmake/cudawrappers-helper.cmake Co-authored-by: Bram Veenboer <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update cmake/cudawrappers-helper.cmake Co-authored-by: Bram Veenboer <[email protected]> * Add updates to inline_local_includes to CHANGELOG * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Bram Veenboer <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues:
This fixes cases such as
Before this PR, the commented out include would be inlined, and both inlined headers would be placed at the top of the file.
Instructions to review the pull request