Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to create slice of device memory #293

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

loostrum
Copy link
Member

Description

Added a DeviceMemory constructor that creates a slice from another DeviceMemory object, without taking ownership.
Tests for both correct and out-of-bounds usage were added.

Related issues:

#291

@loostrum loostrum requested a review from csbnw July 19, 2024 18:03
Copy link
Contributor

@csbnw csbnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have no remarks or suggestions: approved 👍

@loostrum loostrum merged commit dd4f93b into main Jul 22, 2024
7 checks passed
@loostrum loostrum deleted the add-devicememory-slicing branch July 22, 2024 11:43
matmanc pushed a commit that referenced this pull request Jan 20, 2025
* Add option to create slice of device memory

* Add new DeviceMemory constructor to changelog

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants